Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests to @stdlib/utils/compact-adjacency-matrix #2131

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from

Conversation

Pratik772846
Copy link
Contributor

@Pratik772846 Pratik772846 commented Apr 6, 2024

added tests to @stdlib/utils/compact-adjacency-matrix

Resolves #1330

Description

What is the purpose of this pull request?

This pull request:

  • add tests to @stdlib/utils/compact-adjacency-matrix

Related Issues

Does this pull request have any related issues?

This pull request:

Questions

Any questions for reviewers of this pull request?

No.

Other

Any other information relevant to this pull request? This may include screenshots, references, and/or implementation notes.

No.

Checklist

Please ensure the following tasks are completed before submitting this pull request.


@stdlib-js/reviewers

added tests to @stdlib/utils/compact-adjacency-matrix

Fixes stdlib-js#1330
done some changes related to test messages

Fixes stdlib-js#1330
@Pratik772846
Copy link
Contributor Author

image
Hi @kgryte @Planeshifter ,These 2 tests to check property and method are failing for "fromEdge" method .But they are passing for all other methods.What can be the reason behind it?

@kgryte
Copy link
Member

kgryte commented Apr 7, 2024

@Pratik772846 The method is not a prototype method, but a static method. You should be checking for a method on the constructor.

@kgryte kgryte changed the title feat: add tests to @stdlib/utils/compact-adjacency-matrix test: add tests to @stdlib/utils/compact-adjacency-matrix Apr 7, 2024
@kgryte kgryte added the Tests Pull requests specifically adding tests. label Apr 7, 2024
@Pratik772846
Copy link
Contributor Author

Pratik772846 commented Apr 7, 2024

@kgryte Sorry for the oversight. I have updated the tests. Please review it at your convenience.

@Planeshifter Planeshifter self-requested a review April 17, 2024 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tests Pull requests specifically adding tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RFC]: add tests to @stdlib/utils/compact-adjacency-matrix
2 participants