fix: address input multiline #19962

OmarBasem · 2024-05-10T08:13:18Z

fixes: #19788

Summary

This PR fix addresses input to support multiline.

Demo

Screen_Recording_20240510_120614_Status.mp4

status-im-auto · 2024-05-10T08:19:33Z

Jenkins Builds

Click to see older builds (25)

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`261ae0e`	#1	2024-05-10 08:19:33	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`261ae0e`	#1	2024-05-10 08:20:15	~6 min	`tests`	📄`log`
✔️	`261ae0e`	#1	2024-05-10 08:23:47	~10 min	`android`	🤖`apk` 📲
✔️	`261ae0e`	#1	2024-05-10 08:25:17	~11 min	`ios`	📱`ipa` 📲

✔️	`247aba9`	#2	2024-05-10 11:09:56	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`247aba9`	#2	2024-05-10 11:10:50	~6 min	`tests`	📄`log`
✔️	`247aba9`	#2	2024-05-10 11:13:20	~9 min	`android`	🤖`apk` 📲
✔️	`247aba9`	#2	2024-05-10 11:13:58	~9 min	`ios`	📱`ipa` 📲

✔️	`d1e3dbe`	#3	2024-05-14 08:44:37	~4 min	`tests`	📄`log`
❌	`d1e3dbe`	#3	2024-05-14 08:49:36	~9 min	`ios`	📄`log`
✔️	`d1e3dbe`	#3	2024-05-14 08:51:11	~11 min	`android`	🤖`apk` 📲
✔️	`d1e3dbe`	#3	2024-05-14 08:51:15	~11 min	`android-e2e`	🤖`apk` 📲
✔️	`d1e3dbe`	#4	2024-05-14 09:10:26	~10 min	`ios`	📱`ipa` 📲

❌	`cf42a79`	#4	2024-05-15 10:08:40	~4 min	`tests`	📄`log`
✔️	`cf42a79`	#4	2024-05-15 10:10:10	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`cf42a79`	#5	2024-05-15 10:14:06	~9 min	`ios`	📱`ipa` 📲
✔️	`cf42a79`	#4	2024-05-15 10:14:12	~9 min	`android`	🤖`apk` 📲

✔️	`66cb217`	#5	2024-05-15 10:37:10	~5 min	`tests`	📄`log`
✔️	`66cb217`	#5	2024-05-15 10:37:11	~5 min	`android-e2e`	🤖`apk` 📲
✔️	`66cb217`	#5	2024-05-15 10:40:50	~9 min	`android`	🤖`apk` 📲
✔️	`66cb217`	#6	2024-05-15 10:41:12	~9 min	`ios`	📱`ipa` 📲

❌	`01e2d32`	#6	2024-05-16 14:33:48	~4 min	`tests`	📄`log`
✔️	`01e2d32`	#6	2024-05-16 14:38:21	~8 min	`android`	🤖`apk` 📲
✔️	`01e2d32`	#6	2024-05-16 14:40:54	~11 min	`android-e2e`	🤖`apk` 📲
✔️	`01e2d32`	#7	2024-05-16 14:41:23	~11 min	`ios`	📱`ipa` 📲

❔	Commit	#️⃣	Finished (UTC)	Duration	Platform	Result
✔️	`c3d598c`	#8	2024-05-16 15:00:19	~3 min	`tests`	📄`log`
✔️	`c3d598c`	#8	2024-05-16 15:05:57	~9 min	`ios`	📱`ipa` 📲
✔️	`c3d598c`	#7	2024-05-16 15:06:55	~10 min	`android-e2e`	🤖`apk` 📲
✔️	`c3d598c`	#7	2024-05-16 15:06:59	~10 min	`android`	🤖`apk` 📲

✔️	`33b8ac7`	#8	2024-05-16 15:22:13	~6 min	`android`	🤖`apk` 📲
✔️	`33b8ac7`	#9	2024-05-16 15:22:29	~6 min	`tests`	📄`log`
✔️	`33b8ac7`	#8	2024-05-16 15:25:39	~9 min	`android-e2e`	🤖`apk` 📲
✔️	`33b8ac7`	#9	2024-05-16 15:28:04	~12 min	`ios`	📱`ipa` 📲

src/quo/components/inputs/address_input/style.cljs

status-im-auto · 2024-05-13T06:01:58Z

88% of end-end tests have passed

Total executed tests: 52
Failed tests: 5
Expected to fail tests: 1
Passed tests: 46

IDs of failed tests: 727230,704613,727229,702807,702775

IDs of expected to fail tests: 703503

Failed tests (5)

Click to expand

Rerun failed tests

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]` Device 2: `Text` is `0.004 ETH` critical/test_wallet.py:127: in test_wallet_send_asset_from_drawer self._check_balances_after_tx(amount_to_send, sender_balance, receiver_balance, eth_amount_sender, critical/test_wallet.py:98: in _check_balances_after_tx self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Eth amount in the senders wallet is 0.1048 but should be 0.1047 E Eth amount in the receivers wallet is 0.004 but should be 0.0041
2. test_wallet_send_eth, id: 727229
Device 2: Find `Text` by `xpath`: `//android.view.ViewGroup[@content-desc='container']/android.widget.TextView[@text='Ether']/../android.widget.TextView[3]` Device 2: `Text` is `0.004 ETH` `critical/test_wallet.py:112: in test_wallet_send_eth self._check_balances_after_tx(amount_to_send, sender_balance, receiver_balance, eth_amount_sender, critical/test_wallet.py:98: in _check_balances_after_tx self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Eth amount in the senders wallet is 0.1048 but should be 0.1047 E Eth amount in the receivers wallet is 0.004 but should be 0.0041`

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_join_send_text_messages_push, id: 702807

Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
Device 2: Text is Sent

critical/chats/test_group_chat.py:95: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Device 3:

Steps, video, logs

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device 1: Find `Button` by `xpath`: `//*[@text="open community"]` Device 1: Tap on found: Button `critical/test_deep_and_universal_links.py:70: in test_links_open_universal_links_from_chat self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Community 'Open community for e2e' was not requested to join by the url https://status.app/c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE` Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device 1: Find `BrowserTab` by `accessibility id`: `browser-stack-tab` Device 1: Tap on found: BrowserTab `critical/test_deep_and_universal_links.py:114: in test_links_deep_links self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Community 'Open community for e2e' was not requested to join by the deep link status.app://c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE` Device sessions Device 1: Steps, video, logs

Expected to fail tests (1)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (46)

Click to expand

Class TestCommunityOneDeviceMerged:

1. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs
4. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
5. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_mute_chat, id: 703495
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
5. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions Device 1: Steps, video, logs
2. test_wallet_add_remove_watch_only_account, id: 727232
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

src/quo/components/inputs/address_input/style.cljs

ulisesmac

Thanks for the PR @OmarBasem !

qoqobolo · 2024-05-14T09:55:08Z

Hi @OmarBasem, thanks for PR!

ISSUE 1: Address is not aligned with the check icon on Android

Design

status-im-auto · 2024-05-14T11:06:09Z

85% of end-end tests have passed

Total executed tests: 52
Failed tests: 6
Expected to fail tests: 2
Passed tests: 44

IDs of failed tests: 702851,704613,727230,727229,702807,702775

IDs of expected to fail tests: 703503,703495

Failed tests (6)

Click to expand

Rerun failed tests

Class TestDeepLinksOneDevice:

1. test_links_open_universal_links_from_chat, id: 704613
Device 1: Find `Button` by `xpath`: `//*[@text="open community"]` Device 1: Tap on found: Button `critical/test_deep_and_universal_links.py:70: in test_links_open_universal_links_from_chat self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Community 'Open community for e2e' was not requested to join by the url https://status.app/c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE` Device sessions Device 1: Steps, video, logs
2. test_links_deep_links, id: 702775
Device 1: Find `BrowserTab` by `accessibility id`: `browser-stack-tab` Device 1: Tap on found: BrowserTab `critical/test_deep_and_universal_links.py:114: in test_links_deep_links self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Community 'Open community for e2e' was not requested to join by the deep link status.app://c/G1AAAGR0G-IRb2YJD4lRXwLusAFnGrDHGNl6Wt55MIARwVYvarnO873011-fdVSz1kHSan-qq0G96vOaMqyTRhJnQV74KCUr#zQ3shb9irJR66rhG1E8sQZX8pDU3dpGm4daYSmPVDd2e73ewE` Device sessions Device 1: Steps, video, logs

Class TestWalletMultipleDevice:

1. test_wallet_send_asset_from_drawer, id: 727230
# STEP: Getting ETH amount in the wallet of the sender before transaction Device 1: Find `WalletTab` by `accessibility id`: `wallet-stack-tab` critical/test_wallet.py:117: in test_wallet_send_asset_from_drawer sender_balance, receiver_balance, eth_amount_sender, eth_amount_receiver = self._get_balances_before_tx() critical/test_wallet.py:39: in _get_balances_before_tx self.wallet_1.wallet_tab.click() ../views/base_element.py:90: in click element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: WalletTab by accessibility id: `wallet-stack-tab` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception
2. test_wallet_send_eth, id: 727229
Device 1: Swiping right on element SlideButton Device 1: Find `SlideButton` by `xpath`: `//[@resource-id='slide-button-track']` critical/test_wallet.py:109: in test_wallet_send_eth self.wallet_1.send_asset(address=self.receiver['address'], asset_name='Ether', amount=amount_to_send) ../views/wallet_view.py:99: in send_asset self.confirm_transaction() ../views/wallet_view.py:86: in confirm_transaction self.slide_and_confirm_with_password() ../views/wallet_view.py:80: in slide_and_confirm_with_password self.slide_button_track.slide() ../views/base_view.py:257: in slide self.swipe_right_on_element(width_percentage=1.3, start_x=100) ../views/base_element.py:308: in swipe_right_on_element location, size = self.get_element_coordinates() ../views/base_element.py:294: in get_element_coordinates element = self.find_element() ../views/base_element.py:79: in find_element raise NoSuchElementException( Device 1: SlideButton by xpath: `//[@resource-id='slide-button-track']` is not found on the screen; For documentation on this error, please visit: https://www.selenium.dev/documentation/webdriver/troubleshooting/errors#no-such-element-exception

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_activity_center_contact_request_accept_swipe_mark_all_as_read, id: 702851

Device 1: Tap on found: Button
# STEP: Device1 check that contact appeared in contact list mutually

../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen
    httplib_response = self._make_request(
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request
    six.raise_from(e, None)
<string>:3: in raise_from
    ???
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request
    httplib_response = conn.getresponse()
/usr/lib/python3.10/http/client.py:1375: in getresponse
    response.begin()
/usr/lib/python3.10/http/client.py:318: in begin
    version, status, reason = self._read_status()
/usr/lib/python3.10/http/client.py:287: in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
E   http.client.RemoteDisconnected: Remote end closed connection without response

During handling of the above exception, another exception occurred:
activity_center/test_activity_center.py:141: in test_activity_center_contact_request_accept_swipe_mark_all_as_read
    self.device_2.just_fyi('Device1 check that contact appeared in contact list mutually')
../views/base_view.py:410: in just_fyi
    self.driver.execute_script("sauce:context=STEP: %s" % some_str)
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:405: in execute_script
    return self.execute(command, {"script": script, "args": converted_args})["value"]
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/webdriver.py:343: in execute
    response = self.command_executor.execute(driver_command, params)
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:291: in execute
    return self._request(command_info[0], url, body=data)
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/selenium/webdriver/remote/remote_connection.py:312: in _request
    response = self._conn.request(method, url, body=body, headers=headers)
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/urllib3/request.py:78: in request
    return self.request_encode_body(
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/urllib3/request.py:170: in request_encode_body
    return self.urlopen(method, url, **extra_kw)
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/urllib3/poolmanager.py:376: in urlopen
    response = conn.urlopen(method, u.request_uri, **kw)
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:787: in urlopen
    retries = retries.increment(
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/urllib3/util/retry.py:550: in increment
    raise six.reraise(type(error), error, _stacktrace)
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/urllib3/packages/six.py:769: in reraise
    raise value.with_traceback(tb)
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:703: in urlopen
    httplib_response = self._make_request(
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:449: in _make_request
    six.raise_from(e, None)
<string>:3: in raise_from
    ???
../../../../status-app-prs-rerun@tmp/venv/lib/python3.10/site-packages/urllib3/connectionpool.py:444: in _make_request
    httplib_response = conn.getresponse()
/usr/lib/python3.10/http/client.py:1375: in getresponse
    response.begin()
/usr/lib/python3.10/http/client.py:318: in begin
    version, status, reason = self._read_status()
/usr/lib/python3.10/http/client.py:287: in _read_status
    raise RemoteDisconnected("Remote end closed connection without"
 ('Connection aborted.', RemoteDisconnected('Remote end closed connection without response'))

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_join_send_text_messages_push, id: 702807

Device 2: Find Text by xpath: //*[starts-with(@text,'Hey, admin!')]/ancestor::android.view.ViewGroup[@content-desc='chat-item']//*[@content-desc='message-status']/android.widget.TextView
Device 2: Text is Sent

critical/chats/test_group_chat.py:95: in test_group_chat_join_send_text_messages_push
    self.chats[1].chat_element_by_text(message_to_admin).wait_for_status_to_be('Delivered', timeout=120)
../views/chat_view.py:225: in wait_for_status_to_be
    raise TimeoutException("Message status was not changed to %s, it's %s" % (expected_status, current_status))
 Message status was not changed to Delivered, it's Sent

Device sessions

Device 1:

Steps, video, logs

Device 2:

Steps, video, logs

Device 3:

Steps, video, logs

Expected to fail tests (2)

Click to expand

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_mute_chat, id: 703495
# STEP: Change device time so chat will be unmuted by timer Device 2: Long press on `ChatElement` `critical/chats/test_group_chat.py:464: in test_group_chat_mute_chat self.errors.verify_no_errors() base_test_case.py:190: in verify_no_errors pytest.fail('\n '.join([self.errors.pop(0) for _ in range(len(self.errors))])) Chat is still muted after timeout` [[Chat is not unmuted after expected time: https://github.com//issues/19627]] Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_discovery, id: 703503
`Test is not run, e2e blocker` [[reason: [NOTRUN] Curated communities not loading, https://github.com//issues/17852]]

Passed tests (44)

Click to expand

Class TestWalletOneDevice:

1. test_wallet_add_remove_regular_account, id: 727231
Device sessions Device 1: Steps, video, logs
2. test_wallet_add_remove_watch_only_account, id: 727232
Device sessions Device 1: Steps, video, logs

Class TestActivityCenterContactRequestMultipleDevicePR:

1. test_add_contact_field_validation, id: 702777
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_contact_request_decline, id: 702850
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePR:

1. test_activity_center_reply_read_unread_delete_filter_swipe, id: 702947
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_navigation_jump_to, id: 702936
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUi:

1. test_1_1_chat_non_latin_messages_stack_update_profile_photo, id: 702745
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_pin_messages, id: 702731
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_message_reaction, id: 702730
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_1_1_chat_edit_message, id: 702855
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_1_1_chat_push_emoji, id: 702813
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_1_1_chat_text_message_delete_push_disappear, id: 702733
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_1_1_chat_send_image_save_and_share, id: 703391
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_1_1_chat_emoji_send_reply_and_open_link, id: 702782
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestGroupChatMultipleDeviceMergedNewUI:

1. test_group_chat_offline_pn, id: 702808
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
2. test_group_chat_pin_messages, id: 702732
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
3. test_group_chat_reactions, id: 703202
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs
4. test_group_chat_send_image_save_and_share, id: 703297
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs Device 3: Steps, video, logs

Class TestCommunityOneDeviceMerged:

1. test_community_mute_community_and_channel, id: 703382
Device sessions Device 1: Steps, video, logs
2. test_community_copy_and_paste_message_in_chat_input, id: 702742
Device sessions Device 1: Steps, video, logs
3. test_community_navigate_to_channel_when_relaunch, id: 702846
Device sessions Device 1: Steps, video, logs
4. test_restore_multiaccount_with_waku_backup_remove_switch, id: 703133
Device sessions Device 1: Steps, video, logs
5. test_community_undo_delete_message, id: 702869
Device sessions Device 1: Steps, video, logs

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

1. test_1_1_chat_is_shown_message_sent_delivered_from_offline, id: 702783
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_1_1_chat_delete_via_long_press_relogin, id: 702784
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_1_1_chat_mute_chat, id: 703496
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestActivityMultipleDevicePRTwo:

1. test_activity_center_mentions, id: 702957
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_activity_center_admin_notification_accept_swipe, id: 702958
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMerged:

1. test_community_several_images_send_reply, id: 703194
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_edit_delete_message_when_offline, id: 704615
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_message_delete, id: 702839
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_emoji_send_copy_paste_reply, id: 702840
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_mark_all_messages_as_read, id: 703086
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
6. test_community_links_with_previews_github_youtube_twitter_gif_send_enable, id: 702844
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
7. test_community_message_send_check_timestamps_sender_username, id: 702838
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
8. test_community_contact_block_unblock_offline, id: 702894
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
9. test_community_one_image_send_reply, id: 702859
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
10. test_community_unread_messages_badge, id: 702841
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
11. test_community_message_edit, id: 702843
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

Class TestCommunityMultipleDeviceMergedTwo:

1. test_community_markdown_support, id: 702809
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
2. test_community_mentions_push_notification, id: 702786
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
3. test_community_join_when_node_owner_offline, id: 703629
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
4. test_community_hashtag_links_to_community_channels, id: 702948
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs
5. test_community_leave, id: 702845
Device sessions Device 1: Steps, video, logs Device 2: Steps, video, logs

OmarBasem · 2024-05-15T10:32:38Z

Thanks for your testing @qoqobolo, fixed the issue!

qoqobolo · 2024-05-15T13:12:38Z

Thanks @OmarBasem , but it's not aligned on iOS now 🥲

Figma

https://www.figma.com/design/HKncH4wnDwZDAhc4AryK8Y/Wallet-for-Mobile?node-id=689-192841&m=dev

OmarBasem · 2024-05-16T14:29:45Z

Thanks for your testing @qoqobolo! Please check now and let me know

qoqobolo · 2024-05-16T14:49:39Z

Thanks @OmarBasem, PR can be merged.

OmarBasem self-assigned this May 10, 2024

status-github-bot bot added this to REVIEW in Pipeline for QA May 10, 2024

OmarBasem changed the title ~~fix:~~ fix: address input multiline May 10, 2024

OmarBasem added the request-manual-qa label May 10, 2024

OmarBasem requested review from briansztamfater, J-Son89, ulisesmac and a team May 10, 2024 08:14

shivekkhurana requested changes May 10, 2024

View reviewed changes

src/quo/components/inputs/address_input/style.cljs Outdated Show resolved Hide resolved

shivekkhurana self-requested a review May 10, 2024 12:45

shivekkhurana approved these changes May 10, 2024

View reviewed changes

J-Son89 reviewed May 10, 2024

View reviewed changes

src/quo/components/inputs/address_input/style.cljs Show resolved Hide resolved

OmarBasem moved this from REVIEW to E2E Tests in Pipeline for QA May 13, 2024

qoqobolo moved this from E2E Tests to IN TESTING in Pipeline for QA May 13, 2024

qoqobolo self-assigned this May 13, 2024

ulisesmac reviewed May 13, 2024

View reviewed changes

src/quo/components/inputs/address_input/style.cljs Show resolved Hide resolved

ulisesmac approved these changes May 13, 2024

View reviewed changes

qoqobolo force-pushed the fix/address-input branch from 247aba9 to d1e3dbe Compare May 14, 2024 08:39

OmarBasem force-pushed the fix/address-input branch from d1e3dbe to cf42a79 Compare May 15, 2024 10:04

J-Son89 approved these changes May 15, 2024

View reviewed changes

OmarBasem force-pushed the fix/address-input branch from 66cb217 to 01e2d32 Compare May 16, 2024 14:29

qoqobolo added the Tested - OK label May 16, 2024

qoqobolo moved this from IN TESTING to MERGE in Pipeline for QA May 16, 2024

OmarBasem force-pushed the fix/address-input branch from 01e2d32 to c3d598c Compare May 16, 2024 14:56

OmarBasem added 5 commits May 16, 2024 19:15

lint

1f548e5

lint

451c33f

lint

2672161

qa

7726068

qa

33b8ac7

OmarBasem force-pushed the fix/address-input branch from c3d598c to 33b8ac7 Compare May 16, 2024 15:15

OmarBasem merged commit 649a316 into develop May 16, 2024
6 checks passed

Pipeline for QA automation moved this from MERGE to DONE May 16, 2024

OmarBasem deleted the fix/address-input branch May 16, 2024 15:39

fix: address input multiline #19962

fix: address input multiline #19962

Conversation

OmarBasem commented May 10, 2024 • edited

Summary

Demo

status-im-auto commented May 10, 2024 • edited

Jenkins Builds

status-im-auto commented May 13, 2024

88% of end-end tests have passed

Failed tests (5)

Class TestWalletMultipleDevice:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestDeepLinksOneDevice:

Expected to fail tests (1)

Class TestCommunityOneDeviceMerged:

Passed tests (46)

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

Class TestActivityMultipleDevicePR:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestWalletOneDevice:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityMultipleDevicePRTwo:

ulisesmac left a comment

Choose a reason for hiding this comment

qoqobolo commented May 14, 2024

ISSUE 1: Address is not aligned with the check icon on Android

status-im-auto commented May 14, 2024

85% of end-end tests have passed

Failed tests (6)

Class TestDeepLinksOneDevice:

Class TestWalletMultipleDevice:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestGroupChatMultipleDeviceMergedNewUI:

Expected to fail tests (2)

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Passed tests (44)

Class TestWalletOneDevice:

Class TestActivityCenterContactRequestMultipleDevicePR:

Class TestActivityMultipleDevicePR:

Class TestOneToOneChatMultipleSharedDevicesNewUi:

Class TestGroupChatMultipleDeviceMergedNewUI:

Class TestCommunityOneDeviceMerged:

Class TestOneToOneChatMultipleSharedDevicesNewUiTwo:

Class TestActivityMultipleDevicePRTwo:

Class TestCommunityMultipleDeviceMerged:

Class TestCommunityMultipleDeviceMergedTwo:

OmarBasem commented May 15, 2024

qoqobolo commented May 15, 2024

OmarBasem commented May 16, 2024

qoqobolo commented May 16, 2024

OmarBasem commented May 10, 2024 •

edited

status-im-auto commented May 10, 2024 •

edited