feat(search): filter out messages from non-viewable channels #5161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (8)
|
jrainville
force-pushed
the
fix/leaked-channels-in-search
branch
from
09d51a3
to
49b90f1
Compare
osmaczko
approved these changes
May 16, 2024
protocol/messenger.go
Outdated
Comment on lines
4386
to
4403
| if err != nil { | ||
| return nil, err | ||
| } |
There was a problem hiding this comment.
Suggested change
| if err != nil { | |
| return nil, err | |
| } | |
| if err != nil { | |
| if err == communities.ErrOrgNotFound { | |
| continue | |
| } | |
| return nil, err | |
| } |
Otherwise, if a community is removed but the message stays, the search will be broken.
There was a problem hiding this comment.
I'm pretty sure we don't delete the community from the DB, but better safe than sorry
jrainville
force-pushed
the
fix/leaked-channels-in-search
branch
from
49b90f1
to
d86769b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes status-im/status-desktop#14586
Make sure to filter out the non-viewable channels from the search results before sending back
Test run 1000 times: