Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/statusd crashes if wallet enabled #5153

Merged
merged 1 commit into from
May 15, 2024
Merged

Fix/statusd crashes if wallet enabled #5153

merged 1 commit into from
May 15, 2024

Conversation

IvanBelyakoff
Copy link
Contributor

  • fix crash on nil db for statusd if wallet is enabled
  • ensure paths for DBs are created
  • ensure DBs are opened before calling StartNode
  • ignore error if multiacc database is not available

Partially resolves #14693

@status-im-auto
Copy link
Member

status-im-auto commented May 13, 2024 •
edited

Jenkins Builds

Click to see older builds (9)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ c1adbe4 #1 2024-05-13 15:47:27 ~4 min linux 📦zip
✔️ c1adbe4 #1 2024-05-13 15:48:14 ~5 min ios 📦zip
✔️ c1adbe4 #1 2024-05-13 15:48:48 ~5 min android 📦aar
✔️ e0868ee #2 2024-05-13 15:50:37 ~2 min linux 📦zip
✔️ e0868ee #2 2024-05-13 15:51:46 ~2 min android 📦aar
✔️ e0868ee #2 2024-05-13 15:52:12 ~3 min ios 📦zip
✖️ c1adbe4 #1 2024-05-13 16:25:48 ~42 min tests 📄log
✖️ e0868ee #2 2024-05-13 17:09:07 ~43 min tests 📄log
✖️ e0868ee #3 2024-05-14 10:12:11 ~40 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ f2440c2 #3 2024-05-14 11:28:37 ~1 min android 📦aar
✔️ f2440c2 #3 2024-05-14 11:30:53 ~4 min linux 📦zip
✔️ f2440c2 #3 2024-05-14 11:31:59 ~5 min ios 📦zip
✔️ f2440c2 #4 2024-05-14 12:09:17 ~42 min tests 📄log

@IvanBelyakoff IvanBelyakoff force-pushed the fix/statusd_crashes_if_wallet_enabled branch from c1adbe4 to e0868ee Compare May 13, 2024 15:47
@IvanBelyakoff
fix(wallet)_: fix crash on nil db for statusd if wallet is enabled
f2440c2 
Fixed some other issues with prevented startup of statusd:
- ensure paths for DBs are created
- ensure DBs are opened before calling `StartNode`
- ignore error if multiacc database is not available

Updates #14693
@IvanBelyakoff IvanBelyakoff force-pushed the fix/statusd_crashes_if_wallet_enabled branch from e0868ee to f2440c2 Compare May 14, 2024 11:26
stefandunca
stefandunca approved these changes May 14, 2024
View reviewed changes
Copy link
Contributor

@stefandunca stefandunca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great idea, I'm looking forward seeing e2e tests for status-go.

@saledjenic saledjenic requested a review from J-Son89 May 15, 2024 06:35
@IvanBelyakoff IvanBelyakoff merged commit c0e922f into develop May 15, 2024
8 of 9 checks passed
@IvanBelyakoff IvanBelyakoff deleted the fix/statusd_crashes_if_wallet_enabled branch May 15, 2024 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stefandunca stefandunca stefandunca approved these changes

@saledjenic saledjenic saledjenic approved these changes

@osmaczko osmaczko Awaiting requested review from osmaczko

@Cuteivist Cuteivist Awaiting requested review from Cuteivist

@J-Son89 J-Son89 Awaiting requested review from J-Son89

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix status-go daemon crash for wallet API testing
4 participants
@IvanBelyakoff @status-im-auto @stefandunca @saledjenic