-
Notifications
You must be signed in to change notification settings - Fork 241
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix_: loading hash_ratchet_encryption
from database checks group_id
#5138
Conversation
Jenkins BuildsClick to see older builds (12)
|
721e421
to
7376dba
Compare
10f3385
to
96930e4
Compare
@vitvly Igor is still on vacation and we are freezing the branches this Friday or Monday and it would be good to have this fix. Do you have an update on when the mobile part will be ready? |
@jrainville we have an e2e failure on mobile that might be related - i'm still investigating the cause |
@cammellos could you review when you have time. I think this might be a good to have in the next release |
Checked the code and e2e failures in status-im/status-mobile#19969 after several e2e re-runs - seems that the latter are not related to this particular change. |
@jrainville I made this fix under Andrea's control 👌 |
@vitvly Thanks for taking care of this ❤️ |
Fixed
GetHashRatchetCache
implementation.deprecated_key_id
we also usegroup_id
as condition.encryption.GetCurrentTime
, which returned seconds instead of desired milliseconds. This caused issues in tests.Required for #5076
Tested there as well. Keeping a separate PR for clarity.