Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix_: loading hash_ratchet_encryption from database checks group_id #5138

Merged
merged 3 commits into from
May 20, 2024

Conversation

igor-sirotin
Copy link
Contributor

@igor-sirotin igor-sirotin commented May 8, 2024

Fixed GetHashRatchetCache implementation.

  1. For deprecated_key_id we also use group_id as condition.
  2. Fixed time precision in encryption.GetCurrentTime, which returned seconds instead of desired milliseconds. This caused issues in tests.

Required for #5076
Tested there as well. Keeping a separate PR for clarity.

@status-im-auto
Copy link
Member

status-im-auto commented May 8, 2024

Jenkins Builds

Click to see older builds (12)
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 721e421 #1 2024-05-08 23:31:54 ~4 min linux 📦zip
✔️ 721e421 #1 2024-05-08 23:32:30 ~5 min ios 📦zip
✔️ 721e421 #1 2024-05-08 23:33:22 ~5 min android 📦aar
✖️ 721e421 #1 2024-05-09 00:06:48 ~39 min tests 📄log
✔️ 7376dba #2 2024-05-09 20:03:52 ~2 min android 📦aar
✔️ 7376dba #2 2024-05-09 20:04:42 ~3 min ios 📦zip
✔️ 7376dba #2 2024-05-09 20:04:53 ~3 min linux 📦zip
✖️ 7376dba #2 2024-05-09 20:39:21 ~38 min tests 📄log
✖️ 10f3385 #3 2024-05-10 09:05:04 ~1 min tests 📄log
✔️ 10f3385 #3 2024-05-10 09:06:13 ~2 min linux 📦zip
✔️ 10f3385 #3 2024-05-10 09:09:49 ~6 min android 📦aar
✔️ 10f3385 #3 2024-05-10 09:11:43 ~7 min ios 📦zip
Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 96930e4 #4 2024-05-10 09:21:23 ~1 min android 📦aar
✔️ 96930e4 #4 2024-05-10 09:21:54 ~2 min linux 📦zip
✔️ 96930e4 #4 2024-05-10 09:29:08 ~9 min ios 📦zip
✔️ 96930e4 #4 2024-05-10 10:01:47 ~42 min tests 📄log

@vitvly vitvly self-assigned this May 9, 2024
@igor-sirotin igor-sirotin force-pushed the fix/loading-hash-ratchet-keys-from-db branch from 721e421 to 7376dba Compare May 9, 2024 20:00
@jrainville
Copy link
Member

@vitvly Igor is still on vacation and we are freezing the branches this Friday or Monday and it would be good to have this fix. Do you have an update on when the mobile part will be ready?

@vitvly
Copy link
Member

vitvly commented May 17, 2024

@jrainville we have an e2e failure on mobile that might be related - i'm still investigating the cause

@jrainville
Copy link
Member

@cammellos could you review when you have time. I think this might be a good to have in the next release

@jrainville jrainville requested a review from osmaczko May 19, 2024 13:37
@vitvly
Copy link
Member

vitvly commented May 19, 2024

Checked the code and e2e failures in status-im/status-mobile#19969 after several e2e re-runs - seems that the latter are not related to this particular change.

@vitvly vitvly self-requested a review May 20, 2024 11:39
@vitvly vitvly merged commit 20d3a7b into develop May 20, 2024
9 checks passed
@vitvly vitvly deleted the fix/loading-hash-ratchet-keys-from-db branch May 20, 2024 11:39
@igor-sirotin
Copy link
Contributor Author

@cammellos could you review when you have time. I think this might be a good to have in the next release

@jrainville I made this fix under Andrea's control 👌

@igor-sirotin
Copy link
Contributor Author

@vitvly Thanks for taking care of this ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants