Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix_:sync contact request decision #5130

Merged
merged 3 commits into from
May 15, 2024
Merged

fix_:sync contact request decision #5130

merged 3 commits into from
May 15, 2024

Conversation

qfrank
Copy link
Contributor

@qfrank qfrank commented May 8, 2024

relate mobile issue
this PR will fix relate error

@qfrank qfrank self-assigned this May 8, 2024
@qfrank qfrank marked this pull request as ready for review May 8, 2024 11:42
@status-im-auto
Copy link
Member

status-im-auto commented May 8, 2024 •
edited

Jenkins Builds

Click to see older builds (26)
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ df8f51e #1 2024-05-08 11:43:08 ~4 min linux 📦zip
✔️ df8f51e #1 2024-05-08 11:44:15 ~6 min android 📦aar
✔️ df8f51e #1 2024-05-08 11:44:39 ~6 min ios 📦zip
✖️ df8f51e #1 2024-05-08 12:16:58 ~38 min tests 📄log
✔️ acc57aa #2 2024-05-09 02:43:36 ~2 min android 📦aar
✔️ acc57aa #2 2024-05-09 02:44:43 ~3 min ios 📦zip
✔️ acc57aa #2 2024-05-09 02:45:04 ~4 min linux 📦zip
✖️ acc57aa #2 2024-05-09 03:17:57 ~36 min tests 📄log
✔️ 5a46df5 #3 2024-05-09 02:46:41 ~2 min android 📦aar
✔️ 5a46df5 #3 2024-05-09 02:48:40 ~3 min ios 📦zip
✔️ 5a46df5 #3 2024-05-09 02:49:06 ~2 min linux 📦zip
✖️ 5a46df5 #3 2024-05-09 03:54:31 ~36 min tests 📄log
✔️ 0891d44 #4 2024-05-09 12:25:05 ~2 min android 📦aar
✔️ 0891d44 #4 2024-05-09 12:25:32 ~2 min linux 📦zip
✔️ 0891d44 #4 2024-05-09 12:26:36 ~3 min ios 📦zip
✖️ 0891d44 #4 2024-05-09 12:28:19 ~5 min tests 📄log
✔️ 0891d44 #5 2024-05-09 13:43:15 ~42 min tests 📄log
✔️ 2076e60 #5 2024-05-09 14:24:40 ~4 min linux 📦zip
✔️ 2076e60 #5 2024-05-09 14:24:54 ~4 min ios 📦zip
✔️ 2076e60 #5 2024-05-09 14:26:02 ~5 min android 📦aar
✖️ 2076e60 #6 2024-05-09 14:25:56 ~5 min tests 📄log
✔️ 2076e60 #7 2024-05-09 15:13:50 ~43 min tests 📄log
✔️ 49748a9 #6 2024-05-10 00:01:16 ~2 min android 📦aar
✔️ 49748a9 #6 2024-05-10 00:01:29 ~2 min linux 📦zip
✔️ 49748a9 #6 2024-05-10 00:02:32 ~3 min ios 📦zip
✔️ 49748a9 #8 2024-05-10 00:41:00 ~42 min tests 📄log
❔ Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7d9a6ed #7 2024-05-14 02:17:00 ~2 min android 📦aar
✔️ 7d9a6ed #7 2024-05-14 02:17:12 ~2 min linux 📦zip
✔️ 7d9a6ed #7 2024-05-14 02:20:04 ~5 min ios 📦zip
✔️ 7d9a6ed #9 2024-05-14 02:56:43 ~42 min tests 📄log

@qfrank qfrank requested a review from siddarthkay May 8, 2024 11:44
@qfrank qfrank mentioned this pull request May 8, 2024
Merged
@qfrank qfrank force-pushed the fix/sync_contact_decision branch 3 times, most recently from 5a46df5 to 0891d44 Compare May 9, 2024 12:22
@qfrank qfrank requested a review from ilmotta May 9, 2024 13:10
ilmotta
ilmotta approved these changes May 9, 2024
View reviewed changes
Copy link
Contributor

@ilmotta ilmotta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. I left only minor comments 👍🏼

protocol/message_persistence.go Outdated Show resolved Hide resolved
protocol/messenger_contacts.go Outdated Show resolved Hide resolved
protocol/protobuf/pairing.proto Show resolved Hide resolved
protocol/messenger.go Outdated Show resolved Hide resolved
protocol/message_persistence.go Outdated Show resolved Hide resolved
@qfrank
Copy link
Contributor Author

qfrank commented May 9, 2024

All feedback addressed, thanks for your review! @ilmotta

Samyoul
Samyoul approved these changes May 10, 2024
View reviewed changes
Copy link
Member

@Samyoul Samyoul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really nice @qfrank . Thank you

@qfrank qfrank force-pushed the fix/sync_contact_decision branch from 49748a9 to 7d9a6ed Compare May 14, 2024 02:14
@qfrank qfrank merged commit 3b5eab3 into develop May 15, 2024
9 checks passed
@qfrank qfrank deleted the fix/sync_contact_decision branch May 15, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ilmotta ilmotta ilmotta approved these changes

@Samyoul Samyoul Samyoul approved these changes

@igor-sirotin igor-sirotin Awaiting requested review from igor-sirotin

@osmaczko osmaczko Awaiting requested review from osmaczko

@cammellos cammellos Awaiting requested review from cammellos

@siddarthkay siddarthkay Awaiting requested review from siddarthkay

Assignees

@qfrank qfrank

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@qfrank @status-im-auto @ilmotta @Samyoul