chore: use storev3 instead of v2 for history queries #5123
Conversation
|
|
Jenkins BuildsClick to see older builds (52)
|
|
|
2 similar comments
|
|
|
|
|
|
|
|
|
|
wakuv2/waku.go
Outdated
| @@ -126,7 +127,7 @@ type Waku struct { | |||
| storeMsgIDs map[gethcommon.Hash]bool // Map of the currently processing ids | |||
| storeMsgIDsMu sync.RWMutex | |||
|
|
|||
| connStatusChan chan node.ConnStatus | |||
| topicHealthStatusChan chan peermanager.TopicHealthStatus | |||
There was a problem hiding this comment.
This is confusing, is this topic only relates to pubsub topic? if yes, we better make it explicit in peermanager and here.
There was a problem hiding this comment.
For sure the usage of the topicHealtStatus channel needs to be improved. I only added the minimum needed code so the existing functionality is maintained since the connection status feature was removed from go-waku as it did not make sense in the context of having multiple pubsub topics.
Proper usage of this channel must be implemented, following recommendations specified in #4628
|
TODO: must be rebased against #5150 |
richard-ramos
changed the title
|
|
1 similar comment
|
|
|
|
richard-ramos
force-pushed
the
bumpgo_waku-
branch
2 times, most recently
from
602efe2
to
0df2111
Compare
|
|
richard-ramos
force-pushed
the
storev3
branch
5 times, most recently
from
3b5443f
to
d836289
Compare
NOTE: we can't merge this until the code's been dogfooded with the fleet. The fleet does not support storev3 in its current installed version.
Also notice that even though the code is using the topic health status channel, it's usage does not follow the recommendations from #4628 . The behavior on the code is similar to the Conn Status Notification channel it had before.