Move transaction listening to status-go #4953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (32)
|
endulab
force-pushed
the
4351-community-token-refactoring
branch
from
c15ce9e
to
3f9325e
Compare
endulab
commented
Apr 11, 2024
| return nil | ||
| } | ||
|
|
||
| func (s *Service) handleWalletEvent(event walletevent.Event) { |
There was a problem hiding this comment.
This is the main change in the pr.
Here all events are handled and signal is emitted.
endulab
force-pushed
the
4351-community-token-refactoring
branch
from
3f9325e
to
6372de1
Compare
endulab
commented
Apr 11, 2024
| EventCommunityTokenTransactionStatusChanged = "communityToken.communityTokenTransactionStatusChanged" | ||
| ) | ||
|
|
||
| type CommunityTokenTransactionSignal struct { |
There was a problem hiding this comment.
This is signal send to nim.
|
Is this still WIP? That's still the title 😆 |
jrainville
approved these changes
Apr 12, 2024
| @@ -64,3 +66,27 @@ func (db *Database) GetCommunityERC20Metadata() ([]*token.CommunityToken, error) | |||
| } | |||
| return result, rows.Err() | |||
| } | |||
|
|
|||
| // duplicated in persistence | |||
There was a problem hiding this comment.
What does this comment mean?
services/communitytokens/service.go
Outdated
| GetAssetContractData(chainID uint64, contractAddress string) (*AssetContractData, error) | ||
| SafeGetSignerPubKey(ctx context.Context, chainID uint64, communityID string) (string, error) | ||
| DeploymentSignatureDigest(chainID uint64, addressFrom string, communityID string) ([]byte, error) | ||
| // TODO db operations should be moved to communitytokensdatabase |
| return nil | ||
| } | ||
|
|
||
| func (s *Service) handleWalletEvent(event walletevent.Event) { | ||
| if event.Type == transactions.EventPendingTransactionStatusChanged { |
There was a problem hiding this comment.
Since we only handle EventPendingTransactionStatusChanged here, you can reverse the condition and early exit for better readability.
endulab
force-pushed
the
4351-community-token-refactoring
branch
from
6372de1
to
fe9b825
Compare
dlipicar
reviewed
Apr 16, 2024
| transactions.DeployCommunityToken, | ||
| transactions.AutoDelete, | ||
| transactions.Keep, |
There was a problem hiding this comment.
If you change this from Autodelete to Keep, you're in charge of calling Delete to manually remove the entry from the pending_txs table after it fails/succeeds and you do whatever you need with it. I have not seen that though, is it missing or did I miss it?
There was a problem hiding this comment.
It is deleted in communitytokens service after handling event.
endulab
force-pushed
the
4351-community-token-refactoring
branch
4 times, most recently
from
5d139ac
to
2e94b07
Compare
endulab
force-pushed
the
4351-community-token-refactoring
branch
from
2e94b07
to
565f8d1
Compare
Use EventWatcher to catch wallet events. Handling all community tokens wallet events in communitytokens service (database and messenger operations). Adding new signal to nim: CommunityTokenTransactionSignal, which is emitted everytime when the event is received. Issue #4351
endulab
force-pushed
the
4351-community-token-refactoring
branch
from
565f8d1
to
98b7a47
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use EventWatcher to catch wallet events.
Handling all community tokens wallet events in communitytokens service (database and messenger operations).
Adding new signal to nim: CommunityTokenTransactionSignal, which is emitted everytime when the event is received.
Issue #4351