feat: shards.staging fleet #14765
Merged
feat: shards.staging fleet #14765
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (6)
|
jrainville
approved these changes
May 15, 2024
richard-ramos
force-pushed
the
feat/sharding-test
branch
from
58e81a9
to
bd5d5a4
Compare
osmaczko
approved these changes
May 16, 2024
There was a problem hiding this comment.
Thanks for that!
Just a nitpick comment: there are format changes due to the use of nph
I think that we should either start adopting nph in this codebase as well (and perform a separate formatting PR,) or disable nph while editing this repo.
richard-ramos
force-pushed
the
feat/sharding-test
branch
from
bd5d5a4
to
06c6715
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
Adds the shards.test fleet
Requires