fix: Reload contact info whenever the profile dirty flag is dropped #14745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We need to manually request the contact information again because the contact object is not live
alexjba
commented
May 14, 2024
| @@ -129,6 +129,11 @@ Pane { | |||
| d.reload() | |||
| } | |||
|
|
|||
| onDirtyChanged: { | |||
| if (!dirty) | |||
| d.reload() | |||
There was a problem hiding this comment.
this is the main bug fix
Jenkins Builds
|
micieslak
approved these changes
May 16, 2024
alexjba
deleted the
14573-profile-the-profile-preview-shows-the-old-state-after-saving-the-profile
branch
Soon 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does the PR do
closes #14573
We need to manually request the contact information again because the contact object is not live
Other:
Propagate live values to showcase view
Parse display name emojis in the showcase view as well
Parse display name emojis for dirty values as well
Affected areas
Profile dialog
Screenshot of functionality (including design for comparison)
Screen.Recording.2024-05-14.at.11.43.51.mov
Screen.Recording.2024-05-14.at.11.48.11.mov