Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keycard): unable to import account from keycard #14721

Merged
merged 1 commit into from
May 16, 2024
Merged

Conversation

saledjenic
Copy link
Contributor

Handling for recovering Status profile for Linux updated since we don't use biometrics for Linux and that requires slightly different flow.

Closes: #14673

Handling for recovering Status profile for Linux updated since we don't use biometrics for Linux
and that requires slightly different flow.

Closes: #14673
@status-im-auto
Copy link
Member

status-im-auto commented May 12, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ d420fda #1 2024-05-12 12:21:42 ~6 min macos/aarch64 🍎dmg
✔️ d420fda #1 2024-05-12 12:24:20 ~9 min tests/nim 📄log
✔️ d420fda #1 2024-05-12 12:25:38 ~10 min tests/ui 📄log
✔️ d420fda #1 2024-05-12 12:27:01 ~12 min macos/x86_64 🍎dmg
✔️ d420fda #1 2024-05-12 12:36:20 ~21 min linux/x86_64 📦tgz
✔️ d420fda #1 2024-05-12 12:43:54 ~29 min windows/x86_64 💿exe

@saledjenic
Copy link
Contributor Author

@iurimatias it would be good for this one to get into the next release, cause it unblocks users on Linux to recover the Status profile using a keycard.

Copy link
Member

@jakubgs jakubgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't really review the code changes as I know almost nothing about the Nim codebase.

I tried the PR build and the Login with Keycard button appears to do nothing right now. But Enter a seed phrase below it works fine.

@saledjenic
Copy link
Contributor Author

This is how it looks for me when running this PR on Mac, while setting const IS_MACOS* = false to simulate Linux behavior:

-RecoverUsingKeycard.mov

@saledjenic
Copy link
Contributor Author

I can't really review the code changes as I know almost nothing about the Nim codebase.

I tried the PR build and the Login with Keycard button appears to do nothing right now. But Enter a seed phrase below it works fine.

@jakubgs I am pretty sure that on your side because of something keycard lib doesn't respond on the recovering flow and we cannot move further without getting a response. Why that's happening I am not sure, it's up to low-level communication between keycard lib and the reader (keycard) itself.

@saledjenic
Copy link
Contributor Author

@anastasiyaig @glitchminer could you somehow test this PR on Linux, please?

@jakubgs
Copy link
Member

jakubgs commented May 15, 2024

I am pretty sure that on your side because of something keycard lib doesn't respond on the recovering flow and we cannot move further without getting a response.

I just just tested current build of master(d70f2dc) and it gets blocked at PIN entry, but I re-tested the PR build and it works, I got past the PIN entry screen and successfully logged into the app:

image

Not sure what that issue with Login with Keycard button before was about. Bit flaky.

Thanks for the fix.

@saledjenic saledjenic merged commit 6e1fe67 into master May 16, 2024
8 checks passed
@saledjenic saledjenic deleted the fix/issue-14673 branch May 16, 2024 05:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to import account from Keycard
4 participants