-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(keycard): unable to import account from keycard #14721
Conversation
Handling for recovering Status profile for Linux updated since we don't use biometrics for Linux and that requires slightly different flow. Closes: #14673
Jenkins Builds
|
@iurimatias it would be good for this one to get into the next release, cause it unblocks users on Linux to recover the Status profile using a keycard. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't really review the code changes as I know almost nothing about the Nim codebase.
I tried the PR build and the Login with Keycard
button appears to do nothing right now. But Enter a seed phrase
below it works fine.
This is how it looks for me when running this PR on Mac, while setting -RecoverUsingKeycard.mov |
@jakubgs I am pretty sure that on your side because of something keycard lib doesn't respond on the recovering flow and we cannot move further without getting a response. Why that's happening I am not sure, it's up to low-level communication between keycard lib and the reader (keycard) itself. |
@anastasiyaig @glitchminer could you somehow test this PR on Linux, please? |
I just just tested current build of Not sure what that issue with Thanks for the fix. |
Handling for recovering Status profile for Linux updated since we don't use biometrics for Linux and that requires slightly different flow.
Closes: #14673