Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wallet): Show community name in tag #14622

Merged
merged 1 commit into from
May 15, 2024

Conversation

Cuteivist
Copy link
Contributor

@Cuteivist Cuteivist commented May 7, 2024

Closes #14597

What does the PR do

This change is step to streamline the way we show community info

  • Removed community roles from collectibles model
  • Left joined the collectibles model with communities model in Profile and Wallet stores

Affected areas

Profile showcase and wallet collectibles view

Screenshot of functionality (including design for comparison)

  • I've checked the design and this PR matches it

image

image

@status-im-auto
Copy link
Member

status-im-auto commented May 7, 2024

Jenkins Builds

Commit #️⃣ Finished (UTC) Duration Platform Result
✔️ 7103568 #1 2024-05-07 10:55:10 ~6 min tests/nim 📄log
✔️ 7103568 #1 2024-05-07 10:56:53 ~8 min macos/aarch64 🍎dmg
✔️ 7103568 #1 2024-05-07 10:58:39 ~10 min macos/x86_64 🍎dmg
✔️ 7103568 #1 2024-05-07 10:59:51 ~11 min tests/ui 📄log
✔️ 7103568 #1 2024-05-07 11:06:28 ~18 min linux/x86_64 📦tgz
✔️ 7103568 #1 2024-05-07 11:21:37 ~33 min windows/x86_64 💿exe
✔️ aaa8d9e #2 2024-05-13 10:35:54 ~6 min tests/nim 📄log
✔️ aaa8d9e #2 2024-05-13 10:37:17 ~8 min macos/aarch64 🍎dmg
✔️ aaa8d9e #2 2024-05-13 10:39:16 ~10 min macos/x86_64 🍎dmg
✔️ aaa8d9e #2 2024-05-13 10:40:05 ~11 min tests/ui 📄log
✔️ aaa8d9e #2 2024-05-13 10:44:15 ~15 min linux/x86_64 📦tgz
✔️ aaa8d9e #2 2024-05-13 11:02:16 ~33 min windows/x86_64 💿exe

Copy link
Member

@caybro caybro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

ui/app/AppLayouts/Profile/stores/WalletStore.qml Outdated Show resolved Hide resolved
ui/app/AppLayouts/Profile/stores/WalletStore.qml Outdated Show resolved Hide resolved
Copy link
Contributor

@dlipicar dlipicar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome cleanup!
Ideally we can split Collectibles/Collections metadata in a similar way, and have the collectibles controller only handle ownership info.

@Cuteivist Cuteivist force-pushed the bug/collectibles-community-tag-14437 branch from 7103568 to aaa8d9e Compare May 13, 2024 10:28
@Cuteivist Cuteivist merged commit 2565c8a into master May 15, 2024
8 checks passed
@Cuteivist Cuteivist deleted the bug/collectibles-community-tag-14437 branch May 15, 2024 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

No community badge on profile showcase collectibles
4 participants