feat(dapps) add DAppsService component and ConnectDAppModal #14615
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jenkins BuildsClick to see older builds (51)
|
stefandunca
force-pushed
the
dapp_connection-14607
branch
from
1555892
to
8e79216
Compare
stefandunca
force-pushed
the
wc_connect_dapp_modal-14556
branch
from
25db59b
to
7392d0e
Compare
stefandunca
force-pushed
the
dapp_connection-14607
branch
2 times, most recently
from
76b4f9e
to
6841757
Compare
stefandunca
force-pushed
the
dapp_connection-14607
branch
3 times, most recently
from
1a95bf9
to
9ce7926
Compare
stefandunca
requested review from
alexjba,
clauxx,
noeliaSD,
Khushboo-dev-cpp and
saledjenic
8 tasks
saledjenic
approved these changes
May 16, 2024
stefandunca
force-pushed
the
dapp_connection-14607
branch
2 times, most recently
from
5ee9824
to
97a50cc
Compare
1 task
stefandunca
added a commit
that referenced
this pull request
May 16, 2024
stefandunca
added a commit
that referenced
this pull request
May 16, 2024
alexjba
reviewed
May 16, 2024
There was a problem hiding this comment.
Very nice work! 👍
- The only blocker for me is that I can't test it and IDK if it's some setup/config I'm missing or it's a bug somewhere.
Screen.Recording.2024-05-16.at.23.03.39.mov
Debug: WC WalletConnectSDK.wcCall.pair; pairLink: wc:465a7cf1a1dc8cf745c20a25e96203a49a8d0a3f32d53be41b96639a4f969000@2?expiryTimestamp=1715890121&relay-protocol=irn&symKey=5936d61cf931e0d831a749d96f7ce3ada9bbef132fa9f2009946b456db20eb6d (qrc:/app/AppLayouts/Wallet/services/dapps/WalletConnectSDK.qml:224, pair)
Debug: WC WalletConnectSDK.onPairResponse; error: Cannot read property 'pair' of null (qrc:/app/AppLayouts/Wallet/services/dapps/WalletConnectSDK.qml:450, onPairResponse)
- These colours are ok in the app? I can't reach this state
|
Thanks for the feedback.
The only thing I can think of is the limitation we have that only one instance of status-desktop is working loading the SDK. However, in this case you should see an earlier webengine error that storage can't be accessed. I postponed to look more into this. Please try again, closing the other instances if you have open :(
I fixed the background, thanks for the heads up. Please have another look. |
stefandunca
force-pushed
the
dapp_connection-14607
branch
from
97a50cc
to
3493085
Compare
Storybook: also automate related workflows for faster iteration Also extend the inspector utils to handle Loaders and Popups Updates: #14607
Allow to show all selected icons in the network filter Hide checkboxes in the network filter dropdown Updates #14607
Implement the initial Pairing user workflow and disconnect option for the first session. Also - rename pairing modal accordingly (`PairWCModal.qml`) to make room for the proper `ConnectDAppModal.qml` - basic tests for service helpers - update storybook to reflect the new user workflows Closes #14607
stefandunca
force-pushed
the
dapp_connection-14607
branch
from
3493085
to
7fabb60
Compare
alexjba
approved these changes
May 20, 2024
stefandunca
added a commit
that referenced
this pull request
May 21, 2024
stefandunca
added a commit
that referenced
this pull request
May 21, 2024
stefandunca
added a commit
that referenced
this pull request
May 21, 2024
Spent too much time figuring out the puzzle of service->module->view->QML just to call a status-go function. Keeping this attempt for later while moving to a simplified Controller/Provider approach. I will come back to the abstraction when we add tests to use it. Updates: #14615
stefandunca
added a commit
that referenced
this pull request
May 24, 2024
stefandunca
added a commit
that referenced
this pull request
May 24, 2024
stefandunca
added a commit
that referenced
this pull request
May 24, 2024
Spent too much time figuring out the puzzle of service->module->view->QML just to call a status-go function. Keeping this attempt for later while moving to a simplified Controller/Provider approach. I will come back to the abstraction when we add tests to use it. Updates: #14615
stefandunca
added a commit
that referenced
this pull request
May 28, 2024
stefandunca
added a commit
that referenced
this pull request
May 28, 2024
stefandunca
added a commit
that referenced
this pull request
May 28, 2024
Spent too much time figuring out the puzzle of service->module->view->QML just to call a status-go function. Keeping this attempt for later while moving to a simplified Controller/Provider approach. I will come back to the abstraction when we add tests to use it. Updates: #14615
stefandunca
added a commit
that referenced
this pull request
May 28, 2024
stefandunca
added a commit
that referenced
this pull request
May 28, 2024
stefandunca
added a commit
that referenced
this pull request
May 28, 2024
Spent too much time figuring out the puzzle of service->module->view->QML just to call a status-go function. Keeping this attempt for later while moving to a simplified Controller/Provider approach. I will come back to the abstraction when we add tests to use it. Updates: #14615
stefandunca
added a commit
that referenced
this pull request
May 30, 2024
stefandunca
added a commit
that referenced
this pull request
May 30, 2024
stefandunca
added a commit
that referenced
this pull request
May 30, 2024
Spent too much time figuring out the puzzle of service->module->view->QML just to call a status-go function. Keeping this attempt for later while moving to a simplified Controller/Provider approach. I will come back to the abstraction when we add tests to use it. Updates: #14615
stefandunca
added a commit
that referenced
this pull request
May 30, 2024
stefandunca
added a commit
that referenced
this pull request
May 30, 2024
stefandunca
added a commit
that referenced
this pull request
May 30, 2024
Spent too much time figuring out the puzzle of service->module->view->QML just to call a status-go function. Keeping this attempt for later while moving to a simplified Controller/Provider approach. I will come back to the abstraction when we add tests to use it. Updates: #14615
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14607
Implement the initial Pairing user workflow and disconnect option forthe first session.
Also
PairWCModal.qml) to make room for the properConnectDAppModal.qmlHEAD~1: feat(wallet) customize NetworkFilter for dapps displayHEAD~2: chore(dapps) move dApps UX into its own DAppsWorkflow componentHEAD~3: chore(dapps) move wallet connect service code outside popupsHEAD~4: chore(storybook) load WalletConnect SDK in storybook by QRC for nowDemo using test dApp at https://react-app.walletconnect.com/
connect_wc_flow.mov