Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

After confirming the URL, the user should see a modal that would show the dApp metadata (name, icon, url) and the decline/connect buttons #14607

Closed
3 tasks done
Tracked by #14556
stefandunca opened this issue May 4, 2024 · 0 comments · Fixed by #14615
Closed
3 tasks done
Tracked by #14556

After confirming the URL, the user should see a modal that would show the dApp metadata (name, icon, url) and the decline/connect buttons #14607

stefandunca opened this issue May 4, 2024 · 0 comments · Fixed by #14615
Assignees
@stefandunca
Labels
dapp-interactions-team E:Desktop MVP Wallet Connect integration Focusing on integrating the WC functionality and UX flows based on descoped designs feature
Milestone
2.30.0 Beta

Comments

@stefandunca
Copy link
Contributor

stefandunca commented May 4, 2024 •
edited

  • Refactor the DApps wallet connect code to prepare QML code for the upcoming work
    • Move the user workflow responsibility outside the dapp button
    • Create a dapp workflow component to host the user workflow setup
    • Add a JS service to handle the logic between SDK and presentation layer
  • Implement the the dApp Modal for dApp connection display
    • Filter only dapp supported chains
  • Pair using the SDK
@stefandunca stefandunca mentioned this issue May 4, 2024
Closed
8 tasks
@stefandunca stefandunca added E:Desktop MVP Wallet Connect integration Focusing on integrating the WC functionality and UX flows based on descoped designs feature labels May 4, 2024
stefandunca added a commit that referenced this issue May 6, 2024
@stefandunca
chore(dapps) move wallet connect service code outside popups
8b82fcb 
Updates: #14607
stefandunca added a commit that referenced this issue May 6, 2024
@stefandunca
chore(dapps) move dApps UX into its own DAppsWorkflow component
ad2aaa7 
Storybook: also automate related workflows for faster iteration

Also extend the inspector utils to handle Loaders and Popups

Updates: #14607
stefandunca added a commit that referenced this issue May 6, 2024
@stefandunca
feat(dapps) add DAppsService component and ConnectDAppModal
1555892 
Also rename pairing modal accordingly to make room for the proper
ConnectDAppModal.qml

Closes #14607
@stefandunca stefandunca mentioned this issue May 6, 2024
Merged
stefandunca added a commit that referenced this issue May 7, 2024
@stefandunca
feat(dapps) add DAppsService component and ConnectDAppModal
8e79216 
Also rename pairing modal accordingly to make room for the proper
ConnectDAppModal.qml

Closes #14607
stefandunca added a commit that referenced this issue May 10, 2024
@stefandunca
chore(dapps) move wallet connect service code outside popups
e57623c 
Updates: #14607
stefandunca added a commit that referenced this issue May 10, 2024
@stefandunca
chore(dapps) move dApps UX into its own DAppsWorkflow component
7a63939 
Storybook: also automate related workflows for faster iteration

Also extend the inspector utils to handle Loaders and Popups

Updates: #14607
stefandunca added a commit that referenced this issue May 10, 2024
@stefandunca
feat(dapps) add DAppsService component and ConnectDAppModal
76b4f9e 
Also rename pairing modal accordingly to make room for the proper
ConnectDAppModal.qml

Closes #14607
stefandunca added a commit that referenced this issue May 10, 2024
@stefandunca
chore(dapps) move dApps UX into its own DAppsWorkflow component
81c12e0 
Storybook: also automate related workflows for faster iteration

Also extend the inspector utils to handle Loaders and Popups

Updates: #14607
stefandunca added a commit that referenced this issue May 10, 2024
@stefandunca
feat(dapps) add DAppsService component and ConnectDAppModal
b79db01 
Also rename pairing modal accordingly to make room for the proper
ConnectDAppModal.qml

Closes #14607
stefandunca added a commit that referenced this issue May 13, 2024
@stefandunca
chore(dapps) move wallet connect service code outside popups
3b8ea22 
Updates: #14607
stefandunca added a commit that referenced this issue May 13, 2024
@stefandunca
chore(dapps) move dApps UX into its own DAppsWorkflow component
19438f3 
Storybook: also automate related workflows for faster iteration

Also extend the inspector utils to handle Loaders and Popups

Updates: #14607
stefandunca added a commit that referenced this issue May 13, 2024
@stefandunca
feat(dapps) add DAppsService component and ConnectDAppModal
a967b79 
Also rename pairing modal accordingly to make room for the proper
ConnectDAppModal.qml

Closes #14607
stefandunca added a commit that referenced this issue May 13, 2024
@stefandunca
feat(wallet) customize NetworkFilter for dapps display
98a9234 
Allow to show all selected icons in the network filter
Hide checkboxes in the network filter dropdown

Updates #14607
stefandunca added a commit that referenced this issue May 14, 2024
@stefandunca
chore(dapps) move wallet connect service code outside popups
9512783 
Updates: #14607
stefandunca added a commit that referenced this issue May 14, 2024
@stefandunca
chore(dapps) move dApps UX into its own DAppsWorkflow component
d672b5c 
Storybook: also automate related workflows for faster iteration

Also extend the inspector utils to handle Loaders and Popups

Updates: #14607
stefandunca added a commit that referenced this issue May 14, 2024
@stefandunca
feat(wallet) customize NetworkFilter for dapps display
54b396d 
Allow to show all selected icons in the network filter
Hide checkboxes in the network filter dropdown

Updates #14607
stefandunca added a commit that referenced this issue May 14, 2024
@stefandunca
feat(dapps) add DAppsService component and ConnectDAppModal
1a95bf9 
Implement the initial Pairing user workflow and disconnect option for
the first session.

Also

- rename pairing modal accordingly (`PairWCModal.qml`) to make room for the proper
`ConnectDAppModal.qml`
- basic tests for service helpers
- update storybook to reflect the new user workflows

Closes #14607
@clauxx clauxx added this to the 2.30.0 Beta milestone May 14, 2024
stefandunca added a commit that referenced this issue May 14, 2024
@stefandunca
chore(dapps) move wallet connect service code outside popups
26cbbb1 
Updates: #14607
stefandunca added a commit that referenced this issue May 14, 2024
@stefandunca
chore(dapps) move dApps UX into its own DAppsWorkflow component
5202649 
Storybook: also automate related workflows for faster iteration

Also extend the inspector utils to handle Loaders and Popups

Updates: #14607
stefandunca added a commit that referenced this issue May 14, 2024
@stefandunca
feat(wallet) customize NetworkFilter for dapps display
1a1db42 
Allow to show all selected icons in the network filter
Hide checkboxes in the network filter dropdown

Updates #14607
stefandunca added a commit that referenced this issue May 14, 2024
@stefandunca
feat(dapps) add DAppsService component and ConnectDAppModal
9ce7926 
Implement the initial Pairing user workflow and disconnect option for
the first session.

Also

- rename pairing modal accordingly (`PairWCModal.qml`) to make room for the proper
`ConnectDAppModal.qml`
- basic tests for service helpers
- update storybook to reflect the new user workflows

Closes #14607
stefandunca added a commit that referenced this issue May 16, 2024
@stefandunca
feat(dapps) add DAppsService component and ConnectDAppModal
5ee9824 
Implement the initial Pairing user workflow and disconnect option for
the first session.

Also

- rename pairing modal accordingly (`PairWCModal.qml`) to make room for the proper
`ConnectDAppModal.qml`
- basic tests for service helpers
- update storybook to reflect the new user workflows

Closes #14607
stefandunca added a commit that referenced this issue May 16, 2024
@stefandunca
chore(dapps) move wallet connect service code outside popups
798be6a 
Updates: #14607
stefandunca added a commit that referenced this issue May 16, 2024
@stefandunca
chore(dapps) move dApps UX into its own DAppsWorkflow component
febbbc5 
Storybook: also automate related workflows for faster iteration

Also extend the inspector utils to handle Loaders and Popups

Updates: #14607
stefandunca added a commit that referenced this issue May 16, 2024
@stefandunca
feat(wallet) customize NetworkFilter for dapps display
1fb52d1 
Allow to show all selected icons in the network filter
Hide checkboxes in the network filter dropdown

Updates #14607
stefandunca added a commit that referenced this issue May 16, 2024
@stefandunca
feat(dapps) add DAppsService component and ConnectDAppModal
97a50cc 
Implement the initial Pairing user workflow and disconnect option for
the first session.

Also

- rename pairing modal accordingly (`PairWCModal.qml`) to make room for the proper
`ConnectDAppModal.qml`
- basic tests for service helpers
- update storybook to reflect the new user workflows

Closes #14607
stefandunca added a commit that referenced this issue May 17, 2024
@stefandunca
feat(dapps) add DAppsService component and ConnectDAppModal
3493085 
Implement the initial Pairing user workflow and disconnect option for
the first session.

Also

- rename pairing modal accordingly (`PairWCModal.qml`) to make room for the proper
`ConnectDAppModal.qml`
- basic tests for service helpers
- update storybook to reflect the new user workflows

Closes #14607
stefandunca added a commit that referenced this issue May 17, 2024
@stefandunca
chore(dapps) move wallet connect service code outside popups
9f5f1b4 
Updates: #14607
stefandunca added a commit that referenced this issue May 17, 2024
@stefandunca
chore(dapps) move dApps UX into its own DAppsWorkflow component
6871517 
Storybook: also automate related workflows for faster iteration

Also extend the inspector utils to handle Loaders and Popups

Updates: #14607
stefandunca added a commit that referenced this issue May 17, 2024
@stefandunca
feat(wallet) customize NetworkFilter for dapps display
e335c2f 
Allow to show all selected icons in the network filter
Hide checkboxes in the network filter dropdown

Updates #14607
stefandunca added a commit that referenced this issue May 17, 2024
@stefandunca
feat(dapps) add DAppsService component and ConnectDAppModal
7fabb60 
Implement the initial Pairing user workflow and disconnect option for
the first session.

Also

- rename pairing modal accordingly (`PairWCModal.qml`) to make room for the proper
`ConnectDAppModal.qml`
- basic tests for service helpers
- update storybook to reflect the new user workflows

Closes #14607
stefandunca added a commit that referenced this issue May 20, 2024
@stefandunca
chore(dapps) move wallet connect service code outside popups
78775d3 
Updates: #14607
stefandunca added a commit that referenced this issue May 20, 2024
@stefandunca
chore(dapps) move dApps UX into its own DAppsWorkflow component
7cd97a0 
Storybook: also automate related workflows for faster iteration

Also extend the inspector utils to handle Loaders and Popups

Updates: #14607
stefandunca added a commit that referenced this issue May 20, 2024
@stefandunca
feat(wallet) customize NetworkFilter for dapps display
4771f0d 
Allow to show all selected icons in the network filter
Hide checkboxes in the network filter dropdown

Updates #14607
stefandunca added a commit that referenced this issue May 20, 2024
@stefandunca
feat(dapps) add DAppsService component and ConnectDAppModal
ee72ec7 
Implement the initial Pairing user workflow and disconnect option for
the first session.

Also

- rename pairing modal accordingly (`PairWCModal.qml`) to make room for the proper
`ConnectDAppModal.qml`
- basic tests for service helpers
- update storybook to reflect the new user workflows

Closes #14607
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stefandunca stefandunca

Labels
dapp-interactions-team E:Desktop MVP Wallet Connect integration Focusing on integrating the WC functionality and UX flows based on descoped designs feature
Projects
Status Desktop/Mobile Board
Status: Done
Milestone
2.30.0 Beta
Development

Successfully merging a pull request may close this issue.

feat(dapps) add DAppsService component and ConnectDAppModal status-im/status-desktop
2 participants
@clauxx @stefandunca