Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Improve specificity of warning check #8797

Merged
merged 2 commits into from
Apr 14, 2023

Conversation

bashtage
Copy link
Member

@bashtage bashtage commented Apr 14, 2023

Notes:

  • It is essential that you add a test when making code changes. Tests are not
    needed for doc changes.
  • When adding a new function, test values should usually be verified in another package (e.g., R/SAS/Stata).
  • When fixing a bug, you must add a test that would produce the bug in main and
    then show that it is fixed with the new code.
  • New code additions must be well formatted. Changes should pass flake8. If on Linux or OSX, you can
    verify you changes are well formatted by running
    git diff upstream/main -u -- "*.py" | flake8 --diff --isolated
    
    assuming flake8 is installed. This command is also available on Windows
    using the Windows System for Linux once flake8 is installed in the
    local Linux environment. While passing this test is not required, it is good practice and it help
    improve code quality in statsmodels.
  • Docstring additions must render correctly, including escapes and LaTeX.

@bashtage
Copy link
Member Author

xref #8794

Will likely need a helper function to handle casting of pandas ExtensionArrays, if we are to accept them. EIther this, or we reject any array that casts to object in general.

@bashtage bashtage merged commit ad35f85 into statsmodels:main Apr 14, 2023
3 checks passed
@bashtage bashtage deleted the improve-warning-check branch April 14, 2023 09:43
@josef-pkt
Copy link
Member

great, thanks

pre is all green except for the bernstein failure.
I want to ignore that one for now. (likely some change in scipy/boost distribution at boundaries that I did not manage to track down)

@bashtage
Copy link
Member Author

See scipy/scipy#18302

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants