Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Independent hits that are known GWAS variants do not appear in ld-gwas #6

Closed
welchr opened this issue Aug 25, 2017 · 4 comments
Closed

Comments

@welchr
Copy link
Member

welchr commented Aug 25, 2017

Currently each independent hit's LD buddies will be checked if they are known GWAS variants, but the independent hit itself is not.

Will patch by either including the independent hit as an LD buddy with r2=1 or will just directly check each independent hit in the catalog.

@welchr
Copy link
Member Author

welchr commented Aug 28, 2017

This should be fixed by 3cbab1c. Test case added and it passes. Just waiting for user who reported the issue to confirm this also works for them.

@mmoisse
Copy link

mmoisse commented Aug 30, 2017

It creates an other minor issue

$ swiss --download-data
Created data directory: ~/.local/share/swiss/
Error: Failed to download data version from https://portaldev.sph.umich.edu/swiss/swiss_data_1.0.0b5.dev1.version

@welchr
Copy link
Member Author

welchr commented Aug 30, 2017

Linked that file on the server, should work now. I wasn't expecting you would need to re-download the data, though. Are you unable to run swiss without doing --download-data? You should be able to install this right over your existing (or that's the idea, anyway.)

@mmoisse
Copy link

mmoisse commented Aug 30, 2017

On one computer the data was not installed yet, so I needed the --download-data command.
But for the rest it worked nicely, the trick to get it installed was to use the --user flag, otherwise it would say everything was fine but we were still left with the old unpatched version

pip install --no-deps -I --force-reinstall --user git+https://github.com/welchr/swiss.git@bug/indep-hit-self-gwas 

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants