Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add other_names functionality to variants.get_genes #4

Open
grosscol opened this issue Jul 16, 2021 · 2 comments
Open

Add other_names functionality to variants.get_genes #4

grosscol opened this issue Jul 16, 2021 · 2 comments
Labels
enhancement New feature or request

Comments

@grosscol
Copy link
Collaborator

grosscol commented Jul 16, 2021

Issue or current state

Discovered this comment regarding adding more sorting options for the mongo aggregate pipeline of get_genes:

#TODO: add other_names (need to use aggregae https://stackoverflow.com/questions/28889240/mongodb-sort-documents-by-array-elements

From the context of the Stack Overflow post, it appears that this comment is about sorting on a field that is not part of the match.

Resolved when

  • Check if @dtaliun recalls the context and intent of the comment.
  • The intent of the comment is elucidated and a feature issue is filled completed, or determined that an issue is not needed.
@grosscol grosscol added the triage Landing area for issues discovered during development. label Jul 16, 2021
@pjvandehaar
Copy link

pjvandehaar commented Jul 17, 2021

"FURIN" used to be called "PCSK3". If you search Bravo for "PCSK3", you get nothing. .other_names should be used more like this:

image

@grosscol
Copy link
Collaborator Author

@pjvandehaar Thanks for the illustration. That makes sense.

Per @dtaliun

Each gene has a unique identifier (so called Ensemble ID) which starts with “ENSG” and is stored in the gene_id field. Also, a gene has a name (e.g. “PCSK9"), which is stored in the gene_name field. Many genes also have so called “synonyms” or “aliases” (names which were used previously), which are stored in the other_names field (a list of all other names). For example, PCSK9 has a synonym “NARC1”. Currently, the search of variants by gene is done using only gene_id or gene_name fields, but not by other_names. So, if somebody will use “NARC1", no results will be returned.

The intended functionality was to also search through the other_other names field in addition to gene_name and gene_id

@grosscol grosscol added enhancement New feature or request and removed triage Landing area for issues discovered during development. labels Jan 13, 2022
grosscol added a commit that referenced this issue Dec 7, 2023
  Address downstream Bravue issue #4
  Avoid manually coding info about backing data set
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants