Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor user login_disabled property to login_not_required #19

Open
grosscol opened this issue Nov 4, 2022 · 0 comments
Open

Refactor user login_disabled property to login_not_required #19

grosscol opened this issue Nov 4, 2022 · 0 comments
Labels
triage Landing area for issues discovered during development.

Comments

@grosscol
Copy link
Collaborator

grosscol commented Nov 4, 2022

Issue or current state

The bailff blueprint provides auth status route that emits the application login configuration as an attribute of the user auth status. The application config app.config.get('LOGIN_DISABLED') is answering the question "Is the login manager disabled for this application?" An answer of True indicates that users aren't required to log in.

This is confusing when straight mapped as a user authentication status. Login disabled could mean that the user is no longer permitted to log in. It is intending to indicate that the user is not required to login.

Resolved when

API emits user auth status with login_not_required property instead of login_disabled.

@grosscol grosscol added the triage Landing area for issues discovered during development. label Nov 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Landing area for issues discovered during development.
Projects
None yet
Development

No branches or pull requests

1 participant