Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor an put under test deserialize_query_filter #12

Open
grosscol opened this issue Jan 26, 2022 · 1 comment
Open

Refactor an put under test deserialize_query_filter #12

grosscol opened this issue Jan 26, 2022 · 1 comment
Labels
triage Landing area for issues discovered during development.

Comments

@grosscol
Copy link
Collaborator

Issue or current state

The function parses a string into a dictionary suitable for passing to mongo as a filter. It is not a difficult read, but could use some tests to illustrate the expected behavior. It might benefit from being refactored into smaller functions that themselves can be tested

Resolved when

deserialize_query_filter is under test, and a is_value_a_quoted_string function exists under test as well.

@grosscol grosscol added the triage Landing area for issues discovered during development. label Jan 26, 2022
@grosscol
Copy link
Collaborator Author

deserialize_query_filter has been superceded by munge_ui_filters. Still remains to be put under test to illustrate what it's doing more clearly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Landing area for issues discovered during development.
Projects
None yet
Development

No branches or pull requests

1 participant