Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor variants.get_snv into two or more functions #11

Open
grosscol opened this issue Jan 13, 2022 · 0 comments
Open

Refactor variants.get_snv into two or more functions #11

grosscol opened this issue Jan 13, 2022 · 0 comments
Labels
triage Landing area for issues discovered during development.

Comments

@grosscol
Copy link
Collaborator

Issue or current state

In practice, lookup of snv is by accession identifier (rsid) xor by position (chrom-pos)

variants.get_snv(args['variant_id'], None, None, args['full']):
variants.get_snv(None, args['chrom'], args['pos'], args['full']):
variants.get_snv(query, None, None, False):

Resolved when

  • Uses of get_snv are refactored into get_accession_snv and get_position_snv.
  • Tests illustrate expected use.
  • Return type and data format is documented.
@grosscol grosscol added the triage Landing area for issues discovered during development. label Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
triage Landing area for issues discovered during development.
Projects
None yet
Development

No branches or pull requests

1 participant