Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Stream._e returned before throw error #314

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: Stream._e returned before throw error #314

wants to merge 1 commit into from

Conversation

bgfist
Copy link

@bgfist bgfist commented Sep 17, 2020

logic error, rearrange code order.

@staltz staltz closed this Sep 17, 2020
@staltz staltz reopened this Sep 17, 2020
@staltz
Copy link
Owner

staltz commented Sep 17, 2020 •
edited

Hi @bgfist :)
Thanks for submitting this PR, we appreciate any kind of desire to help. Before merging this PR could you notice that we need a new test that describes the bug that you're fixing.

@staltz
Copy link
Owner

staltz commented Sep 17, 2020

Also, notice that the tests are failing in CI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bgfist @staltz