example: custom numeric type #370
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcarpent
reviewed
May 19, 2023
There was a problem hiding this comment.
Thanks @ofloveandhate for the PR. I will make a pass on it when I have time in order to align it with the rest of the project. Is it fine for you?
jcarpent
force-pushed
the
feature/example_custom_numeric_type
branch
from
765d4be
to
284a5f8
Compare
|
TODO:
|
|
I tried to use the code in this PR, and it doesn't install correctly on my Mac. I observe the following issues:
I think all of these are issues with the CMakeLists.txt file. |
|
I would love to be able to build upon this to work on some problems I'm seeing with custom numeric types in EigenPy, and make this example more complete, but I am finding the setup stuff is a barrier. Thanks! |
directly derived from other files inside eigenpy
for more information, see https://pre-commit.ci
jcarpent
force-pushed
the
feature/example_custom_numeric_type
branch
from
284a5f8
to
6566e87
Compare
now makes a library without `lib` at front, and with `.so` at the end. I was able to get this to compile and import using libraries installed via `conda`.
for more information, see https://pre-commit.ci
* brought in the real visitor from stack-of-tasks#365 (from which I had previously derived the complex visitor). * provided the `real` and `imag` properties the code could be cleaner, but now I can actually import the built library, make a complex, get its real/imag parts, do arithmetic, and use dot-tab completion in ipython without crashes. (motivation: i'm working towards a MWE for the alignment issues I get in Bertini 2. either I can replicate it using this code, in which case we can find the bug / whatever in eigenpy, or I fail, and I reveal the bug in MY code.)
…com/ofloveandhate/eigenpy into feature/example_custom_numeric_type
for more information, see https://pre-commit.ci
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request is an example of building against EigenPy to expose Eigen objects with custom numeric types from C++. This is in response to #365.
This example at time of PR builds and installs, but not fully correctly. It doesn't install usable Python bindings, so the example Python code is not runnable. Maybe you could do that last step? So that the built bindings can actually be used in Python?