Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update v15 #739

Merged
merged 3 commits into from
Nov 10, 2020
Merged

Update v15 #739

merged 3 commits into from
Nov 10, 2020

Conversation

clehner
Copy link
Contributor

@clehner clehner commented Nov 9, 2020

Since #734, I am using and recommending ssb-server v15 over v16.

I would like to publish a new patch release of v15 with the following
changes:

There are no indexing conflicts that I am aware of between v15 and v16 currently - v16 just adds ssb-private1 - so it is safe to run both of these with the same ~/.ssb directory (not at the same time, of course). Running v15 is useful for recovering from #734.

clehner and others added 3 commits November 9, 2020 07:32
Problem: The SSB-Server configures `caps` as a buffer, which breaks all
connections because it's supposed to be a base64 string.

Solution: Use the base64 string just like we're doing in SSB-Config.
@ahdinosaur
Copy link
Contributor

merging, as i'm keen to upgrade ssb-pub with this release.

ref: ahdinosaur/ssb-pub#37

@ahdinosaur ahdinosaur merged commit e524db2 into v15 Nov 10, 2020
@ahdinosaur
Copy link
Contributor

hm, i made a new version 15.3.0, but not sure how to npm publish, npm test and specifically compatibility seems to always end on an error. i see #628 (comment), but not sure how to resolve.

@ahdinosaur
Copy link
Contributor

ahdinosaur commented Nov 10, 2020

yeah, seems like we're in a situation with:

when two plugins have a dev dep that conflicts, the pretest script fails. a@2 a@3 would fail, it this case you will need to fix the plugins.

oh no, shaving yaks...

  • ssb-ebt wants:
    • cat-names@3
    • dog-names@2
  • ssb-replicate wants:
    • cat-names@2
    • dog-names@1

vs.

  • ssb-ooo wants:
    • rimraf@3
  • ssb-blobs wants:
    • rimraf@2

@ahdinosaur
Copy link
Contributor

well compatibility cycles between two sets of dev dependencies. both of them pass, so do i yolo and force publish? 😺 i'll make some lunch.

@ahdinosaur
Copy link
Contributor

published ssb-server@15.3.0 🎉

ahdinosaur added a commit to ahdinosaur/ssb-pub that referenced this pull request Nov 10, 2020
@clehner
Copy link
Contributor Author

clehner commented Nov 10, 2020

Thanks @ahdinosaur

@clehner clehner deleted the v15-updates branch November 10, 2020 13:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants