extract config, and add working config from patchbay #24
Conversation
|
I see one of these socket errors (where previously I'd see 5+), but patchbay seems to run fine err? { Error: connect ECONNREFUSED /home/mixmix/.ssb/socket
at Object._errnoException (util.js:1024:11)
at _exceptionWithHostPort (util.js:1046:20)
at PipeConnectWrap.afterConnect [as oncomplete] (net.js:1182:14)
code: 'ECONNREFUSED',
errno: 'ECONNREFUSED',
syscall: 'connect',
address: '/home/mixmix/.ssb/socket' }
|
| // const minimist = require('minimist') | ||
|
|
||
| module.exports = function buildConfig ({ appname }) { | ||
| // mix: note ssb-config uses RC, which loads config opts from process.argv |
There was a problem hiding this comment.
hmmm on reading docs, I don't think RC actually loads things from process.argv ):
So this code should be reinstated. However, I still don't know what the last line does :
argv = ~i ? argv.slice(0, i) : argv 
|
Sorry that I can鈥檛 add anything here. The RC vs JSON config is black magic that always confused me... mostly just that we have two config file systems to begin with. Re the socket error is fine as long as it works in the end. The Client tries to redial until it works. The fluctuation you see should just be difference in sbot boot time before it can accept connections. |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
|
Anything I can do to help with this? Not sure if scuttle-shell is still active, but noticed this PR was still open. |
|
Is this still relevant? If so, what is blocking it? Is there anything you can do to help move it forward? |
scuttle-shell wasn't quite working for me. When I went to investigate, I noticed the config was a bit odd compared to
patchbay. I'm still getting my head around this connections config stuff.But I've found using this branch in patchbay everything works happily (that I've seen so far!)
In this PR:
./config.jsssb-configuses RC, which I think does everything we want for loading config?! this needs attention