Transfer update-ss3-version.yml from stock-synthesis workflows repo #410
Conversation
e-perl-NOAA
added
topic --- ghaction
|
@kellijohnson-NOAA I went ahead and created this branch and PR in the case that you select this option for the ss3sim repo. I know you had suggested it possibly going into ghactions4r. |
|
@k-doering-NOAA should we just host the workflow on ss3sim/ss3sim and keep it a reusable workflow that we can both call? I don't mind "trying" to maintain it 😄 |
That works for me! |
|
Also, I'm happy to help with maintenance issues, if needed :) |
|
Okay, then if everyone is good with this then I will go ahead and merge this PR and update the SSMSE workflow to call from the ss3sim repo. |
|
@e-gugliotti-NOAA please do not merge this PR. As is, the workflow is no longer reusable and the call for the reusable workflow is deleted. The last commit needs to be removed and the location of the reusable workflow needs to be updated in the call yml file. |
* update echo output * add spaces to build-ss3.yml * fix windows run * try echo * try echo ouput * try echo updates * revert echo * update windows path * update out-file windows * try echo again * echo windows update * revert back echo windows * revert back windows * add $env to windows tag * update to recent stock synthesis v3.30.20
e-perl-NOAA
force-pushed
the
transfer-workflow
branch
from
266fcf0
to
c596142
Compare
|
@kellijohnson-NOAA is this (the most recent commit) what you mean? |
| @@ -12,6 +12,7 @@ name: Update SS3 version in R package | |||
|
|
|||
| on: | |||
| workflow_call: | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
You cannot use a reusable workflow on dispatch, it can only be called. So, we do not need this edit.
| @@ -71,4 +72,5 @@ jobs: | |||
|
|
|||
| Auto-generated by [update-ss3-version.yml][1]. Binaries from ${{ steps.get-link-to-release.outputs.link_to_release }}. | |||
|
|
|||
| [1]: https://github.com/nmfs-stock-synthesis/workflows/tree/main/.github/workflows/update-ss3-version.yml | |||
There was a problem hiding this comment.
We will not need to test this workflow out because we already know it works. So, these edits can be removed.
| @@ -5,4 +5,4 @@ on: | |||
| name: call-update-ss3 | |||
| jobs: | |||
| call-workflow: | |||
| uses: nmfs-stock-synthesis/workflows/.github/workflows/update-ss3-version.yml@main | |||
| uses: ss3sim/ss3sim/.github/workflows/update-ss3-version.yml@main | |||
e-perl-NOAA
force-pushed
the
transfer-workflow
branch
from
7dc643b
to
c366090
Compare
|
still working on this...git is being finicky right now. |
e-perl-NOAA
force-pushed
the
transfer-workflow
branch
from
c366090
to
232b4dc
Compare
update call-update-ss3-version to call from ss3sim repo update call-update-ss3-version.yml to ss3sim repo
e-perl-NOAA
force-pushed
the
transfer-workflow
branch
from
232b4dc
to
e600799
Compare
Transfer update-ss3-version.yml (and git history) from stock-synthesis workflows repo and delete call-update-ss3-version.yml as part of issue #416 in the stock-synthesis repo.