Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate convert_to_wide #328

Open
Tracked by #327
kellijohnson-NOAA opened this issue Oct 17, 2021 · 3 comments
Open
Tracked by #327

deprecate convert_to_wide #328

kellijohnson-NOAA opened this issue Oct 17, 2021 · 3 comments
Assignees
Labels
topic --- results pertains to generating, reading, or visualizing the results type --- upkeep general package maintenance work that makes future development #' easier

Comments

@kellijohnson-NOAA
Copy link
Contributor

@k-doering-NOAA do you think that we can remove

convert_to_wide <- function(lng) {

Seems like the long results have been around long enough that we might not need to provide support for the "old" way.

@kellijohnson-NOAA kellijohnson-NOAA added the topic --- results pertains to generating, reading, or visualizing the results label Oct 17, 2021
@k-doering-NOAA
Copy link
Contributor

I'm not sure... sometimes it is helpful to have wide rather than long format for some plots. I'll have to think more about this.

@kellijohnson-NOAA kellijohnson-NOAA added the type --- upkeep general package maintenance work that makes future development #' easier label Dec 1, 2021
@kellijohnson-NOAA
Copy link
Contributor Author

@k-doering-NOAA just wanted to double check that {SSMSE} does not use type = "wide" because I am planning on deprecating this functionality this week. I searched {SSMSE} for "wide" and did not find it wrt {ss3sim} but I just wanted to make sure.

@k-doering-NOAA
Copy link
Contributor

Thanks for checking, you are correct, {SSMSE} doesn't use type = "wide"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic --- results pertains to generating, reading, or visualizing the results type --- upkeep general package maintenance work that makes future development #' easier
Projects
None yet
Development

No branches or pull requests

2 participants