Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor get_results_all() to be more efficient #327

Open
4 tasks
kellijohnson-NOAA opened this issue Oct 17, 2021 · 4 comments
Open
4 tasks

Refactor get_results_all() to be more efficient #327

kellijohnson-NOAA opened this issue Oct 17, 2021 · 4 comments
Labels
topic --- results pertains to generating, reading, or visualizing the results type --- upkeep general package maintenance work that makes future development #' easier

Comments

@kellijohnson-NOAA
Copy link
Contributor

kellijohnson-NOAA commented Oct 17, 2021 •
edited

Problem

There are multiple issues that pertain to the results because the function is large and slow, this issues summarizes them.

Proposal
@kellijohnson-NOAA kellijohnson-NOAA added the topic --- results pertains to generating, reading, or visualizing the results label Oct 17, 2021
@k-doering-NOAA
Copy link
Contributor

@kellijohnson-NOAA , feel free to assign me to this, if you would like me to work on it.

@kellijohnson-NOAA
Copy link
Contributor Author

@k-doering-NOAA thanks for volunteering to work on this. I think that some refactoring needs to happen here to compartmentalize the code. Things are just too complicated as written, and I don't think that it needs to be this convoluted. I would like to see more smaller functions to reduce redundancy and makes things more modular; thanks @msupernaw for adding modularity to my vocabulary 😄.

@kellijohnson-NOAA kellijohnson-NOAA added the type --- upkeep general package maintenance work that makes future development #' easier label Oct 19, 2021
@k-doering-NOAA
Copy link
Contributor

I just saw this issue :( I guess it got buried after I agreed to work on it! I'm so sorry, Kelli.

@k-doering-NOAA k-doering-NOAA removed their assignment Jul 29, 2022
@kellijohnson-NOAA
Copy link
Contributor Author

No worries @k-doering-NOAA I plan on looking at it shortly :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
topic --- results pertains to generating, reading, or visualizing the results type --- upkeep general package maintenance work that makes future development #' easier
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kellijohnson-NOAA @k-doering-NOAA