Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve 3 tests #28

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve 3 tests #28

wants to merge 1 commit into from

Conversation

philipbutler
Copy link

Most of the tests are too basic (a = [0, 1, 2, 3], a = [1, 1, 1, 1]) which causes some wrong solutions to pass.

For example, it's intended that a gets read from, but if one peeks at the expected result, they can avoid reading altogether by writing out[_thread_index_] = thread_index.

To try and improve the first 3 tests, I used a numpy random integer generator, populating a with values 0-9.

If this is a good proposal and is accepted, I would be happy to update the other tests.

Thanks for making a great intro to GPU programming :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant