fix #296 - add go modules support #313
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
s-kostyaev
force-pushed
the
add-modules-support
branch
from
4921266
to
780b45a
Compare
Signed-off-by: Sergey Kostyaev <sergey.kostyaev@bitfury.com>
s-kostyaev
force-pushed
the
add-modules-support
branch
from
780b45a
to
021d805
Compare
|
This works nicely for me. I had to change the generate command to And for anyone else wanting to test I added a temporary line to my go.mod file to use this PR: |
|
Confirming, works good. It just needs to be confirmed to be working for non-mod projects for backward compat |
|
@roobre, can you help to fix the failing tests? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add go modules support with golang.org/x/tools/go/packages