Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise excluded tests #33

Open
wants to merge 4 commits into
base: squeak-trunk
Choose a base branch
from

Conversation

LinqLover
Copy link
Contributor

No description provided.

@marceltaeumel
Copy link
Member

Why is this a draft?

@LinqLover
Copy link
Contributor Author

Because I had waited for the CI to pass and then forgot it. :-) I think you can merge it now (if you like it). :-)

@LinqLover LinqLover marked this pull request as ready for review June 16, 2022 13:52
LinqLover referenced this pull request Jun 16, 2022
… abort test execution on the CI. Unfortunately, STON has no syntax for comments.
@marceltaeumel
Copy link
Member

Because I had waited for the CI to pass and then forgot it.

That's not how you use a draft.

@LinqLover
Copy link
Contributor Author

Because I had waited for the CI to pass and then forgot it.

That's not how you use a draft.

I think we had this discussion earlier. 😅 For me, a draft PR is just an open door for interested lurkers and the opposite of "ready to review": https://github.blog/2019-02-14-introducing-draft-pull-requests/

Anyway, in this case, I needed to create a PR in order to get feedback from the CI on my changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants