Improve preconditions #957
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Egorand
approved these changes
Aug 1, 2020
| "KotlinPoet doesn't allow setting the inline modifier on " + | ||
| "properties. You should mark either the getter, the setter, or both inline." | ||
| } | ||
| val getter = getter |
There was a problem hiding this comment.
Not sure I get why local variables are needed here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
initblocks of the Spec class and in thebuildfunction. There was even a redundant repeated check in FunSpec. I moved these checks into the build method. Since the Spec constructor is called from the build method, this shouldn't change behavior.