Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AttributedLabel Link Accessibility #459

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

AttributedLabel Link Accessibility #459

wants to merge 2 commits into from
+61 −0

Conversation

RoyalPineapple
Copy link
Collaborator

@RoyalPineapple RoyalPineapple commented May 30, 2023 •
edited

Updating attributed label's links to more closely mirror the SwiftUI accessibility experience

SwiftUI.Link.mp4

This is our current implementation, which doesn't announce links properly.

WithoutLinks.mov

Here is the new version, announcing links as they are read.

WithLinks.mp4

@RoyalPineapple RoyalPineapple force-pushed the alex/LinkAccessibility branch 2 times, most recently from bc23c22 to e6457d0 Compare June 8, 2023 17:00
@RoyalPineapple RoyalPineapple marked this pull request as ready for review June 29, 2023 17:34
@RoyalPineapple RoyalPineapple requested a review from a team as a code owner June 29, 2023 17:34
@RoyalPineapple RoyalPineapple marked this pull request as draft November 28, 2023 16:54
@kyleve
Copy link
Collaborator

kyleve commented Nov 29, 2023

It looks like there's some failing tests:

Failing tests:

	AttributedLabelTests.test_linkAttribute()
	AttributedLabelTests.test_textContainerRects()

@RoyalPineapple RoyalPineapple force-pushed the alex/LinkAccessibility branch 2 times, most recently from ec73157 to 736cd9e Compare November 30, 2023 17:28
@RoyalPineapple RoyalPineapple force-pushed the alex/LinkAccessibility branch 4 times, most recently from 7bfd79a to 88a7dca Compare November 30, 2023 22:17
@RoyalPineapple RoyalPineapple marked this pull request as ready for review November 30, 2023 22:47
@RoyalPineapple
Copy link
Collaborator Author

RoyalPineapple commented Dec 5, 2023 •
edited

Replaced with #473

@RoyalPineapple RoyalPineapple reopened this Dec 7, 2023
@robmaceachern
Copy link
Member

@RoyalPineapple Moving to draft because I think this was addressed elsewhere but feel free to reopen if needed!

@robmaceachern robmaceachern marked this pull request as draft March 14, 2024 18:16
@RoyalPineapple RoyalPineapple mentioned this pull request Apr 18, 2024
Merged
@RoyalPineapple RoyalPineapple marked this pull request as ready for review May 30, 2024 18:19
@RoyalPineapple
inserting the word link after all links to mimic the implementation o…
599f360 
…f the .link string attribute which we strip to allow our own styling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyleve kyleve kyleve approved these changes

@meherkasam-square meherkasam-square meherkasam-square approved these changes

@n8chur n8chur Awaiting requested review from n8chur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RoyalPineapple @kyleve @robmaceachern @meherkasam-square