Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(mysql): Fix the generation of between keyword in CTE #3164

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

eyasy1217
Copy link

Fixes #2983

The incorrectly generated code in this issue is generated as follows.

const listAuthorsWithCTE = `-- name: ListAuthorsWithCTE :many
WITH page AS (SELECT id FROM authors WHERE authors.created_at BETWEEN ? AND ?)
SELECT authors.id, name, bio, created_at, page.id FROM authors
INNER JOIN page ON page.id = authors.id
ORDER BY name
`

type ListAuthorsWithCTEParams struct {
	FromCreatedAt   time.Time
	ToCreatedAt     time.Time
}
rows, err := q.db.QueryContext(ctx, listAuthorsWithCTE, arg.FromCreatedAt, arg.ToCreatedAt)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BETWEEN keyword in CTE generates duplicate params
1 participant