Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(analyzer): Implement parameter type annotations #3075

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

andrewmbenton
Copy link
Collaborator

A first step towards implementing #2800.

I'd like to add some more tests to meta_test.go if I have time.

Some things to consider before merging:

  1. What to do about the additional comments? If you look at the test output you'll see that the new comments end up in generated source. Should we swallow them?
  2. Should I implement the forcenotnull thing with a map instead of a pointer to a bool? Might be simpler...

The changes to ParamRef are pure refactor.

Copy link
Collaborator

@kyleconroy kyleconroy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Add a test for array types
  • Verify types if the database analyzer is active
  • Switch the bool* to an enum

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants