-
Notifications
You must be signed in to change notification settings - Fork 65
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use asyncio to block forever rather than time sleep #309
Conversation
Thanks for raising this. However, all code in the (to avoid the code rewriting, you can also extract to the Sorry for you to run into this. I should probably get around to writing a contribution guide that explains all of this soon 😅 |
Oof that's probably why when I use the requirements.txt to point to my git repo my changes are not being reflected and I was wondering WTF... because this is the second one I am doing patch work for my weekend project jath03/openrgb-python#72 was the first and it seemed to work. |
BTW if |
It perhaps doesn't have to be committed, and I've gone back and forth on whether it should be or not, but ultimately it made it easier for linting tools, mypy, sphinx/readthedocs, etc. to all work correctly and allows someone to see the source online like, say, if they're investigating a stacktrace that points to a line in the |
I yield. I am not familiar with Python enough to convert what I have to an |
https://stackoverflow.com/questions/78465203/internally-is-asyncio-run-forever-basically-a-while-true-loop/78465221#78465221
https://stackoverflow.com/a/78463084/242042