test: improve test assertions #1473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@anyulled Please sign the Contributor License Agreement! Click here to manually synchronize the status of this Pull Request. See the FAQ for frequently asked questions. |
|
@anyulled Thank you for signing the Contributor License Agreement! |
zyberzebra
suggested changes
Mar 16, 2024
src/test/java/org/springframework/samples/petclinic/model/ValidatorTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/springframework/samples/petclinic/owner/OwnerControllerTests.java
Show resolved
Hide resolved
src/test/java/org/springframework/samples/petclinic/service/ClinicServiceTests.java
Outdated
Show resolved
Hide resolved
src/test/java/org/springframework/samples/petclinic/system/CrashControllerTests.java
Show resolved
Hide resolved
…datorTests.java Co-authored-by: zral <73640367+zyberzebra@users.noreply.github.com>
…inicServiceTests.java Co-authored-by: zral <73640367+zyberzebra@users.noreply.github.com>
|
@zyberzebra Who else needs to approve this pull request for merging it? |
|
One of the Maintainers. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
assertThat()method must be followed by an assertion invocation, otherwise what is intended to be a test doesn't actually verify anything.isEqualTo()withhasToString()assertion increases readability of the code for verifyingtoString()methods.isNotEqualTo(0)withisNotZero()to improve readability.assertThat(owner6.getPets().size()).isEqualTo(found + 1)withassertThat(owner6.getPets()).hasSize(found + 1);for better code readability.assertEqual()assertion with AssertJassertThat().isEqualTo()for improved readability and consistent use within the project.solves #1474