Add Gradle Checkstyle #1444
Merged
Add Gradle Checkstyle #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You had to duplicate the suppressions XML file? Seems like a dangerous move (not that it changes very often, but it will definitely break next time someone updates one of them and didn't know about the other). |
I agree, I was trying to avoid this but was struggling to make the nohttp check use this config. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous attempt to add a checkstyle to gradle failed, but after more thorough testing this should work.
I also made the paths in the suppression file OS agnostic as previously if you ran
./gradlew buildfollowed bymvn installyou would get a checkstyle failure on windows as it would not pick up on the path for the build suppressions.