Add user friendly validation messages #1442
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in #1351 the validation messages are not very user-friendly. Additionally the validation of the telephone number (which is a String value) with
@Digits
is faulty because leading zeros are ignored when converting from String to BigDecimal in the DigitsValidator. This faulty behaviour was also visible in the tests where an 11 digit number was parsed as the telephone number.These caused the failing tests in #1361.