Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #1262 adding new message in Chinese #1263

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

DaZuiZui
Copy link

adding new message in Chinese

@pivotal-cla
Copy link

@DaZuiZui Please sign the Contributor License Agreement!

Click here to manually synchronize the status of this Pull Request.

See the FAQ for frequently asked questions.

@pivotal-cla
Copy link

@DaZuiZui Thank you for signing the Contributor License Agreement!

@dsyer
Copy link
Member

dsyer commented Jun 22, 2023

I can only see question marks ("????" etc.) in messages_cn.properties, in browser and also when I checkout your branch. Did it get destroyed on the way to github, or on the way to my computer?

@dsyer
Copy link
Member

dsyer commented Jun 26, 2023

I see the content now, thank you. Did you test it in a browser? I think the code for Chinese language is actually "zh" (not "cn"), so I don't expect it to work yet.

…ile name has been corrected

The correct file name has been corrected
duplicate=已在使用中
nonNumeric=非数字
duplicateFormSubmission=重复表单提交
typeMismatch.date=失效时间
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Google translate suggests 失效日期 (and renders 失效时间 as "expiration time" which seems wrong)?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you changed it to 到期时间. Google translates that to "expire date" which also seems wrong. We want an "invalid date" message, not an "expiration" message. Is my suggestion also wrong?

In Chinese, the meaning of these two words is the same, it has been corrected.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants