Vector Store polish #686
Open
Vector Store polish #686
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… down the application on startup.
…incompatabilities.
tzolov
requested changes
May 9, 2024
| @@ -8,10 +8,10 @@ | |||
| <version>1.0.0-SNAPSHOT</version> | |||
| <relativePath>../../pom.xml</relativePath> | |||
| </parent> | |||
| <artifactId>spring-ai-azure-vector-store</artifactId> | |||
| <artifactId>spring-ai-azure-store</artifactId> | |||
There was a problem hiding this comment.
You need to updated all places the spring-ai-azure-vector-store including poms and docs
| import com.azure.search.documents.models.SearchOptions; | ||
| import com.azure.search.documents.models.VectorSearchOptions; | ||
| import com.azure.search.documents.models.VectorizedQuery; | ||
| import com.azure.search.documents.indexes.models.*; |
There was a problem hiding this comment.
Spring Framework code convention: Wildcard imports such as import java.util.* or import static org.assertj.core.api.Assertions.* are forbidden, even in test code.
https://github.com/spring-projects/spring-framework/wiki/Code-Style#import-statements
| import org.springframework.util.Assert; | ||
| import org.springframework.util.CollectionUtils; | ||
| import org.springframework.util.StringUtils; | ||
|
|
||
| import java.util.*; |
| import com.datastax.oss.driver.api.core.cql.PreparedStatement; | ||
| import com.datastax.oss.driver.api.core.cql.Row; | ||
| import com.datastax.oss.driver.api.core.cql.SimpleStatement; | ||
| import com.datastax.oss.driver.api.core.cql.*; |
| import org.springframework.ai.vectorstore.CassandraVectorStoreConfig.SchemaColumn; | ||
| import org.springframework.ai.vectorstore.filter.FilterExpressionConverter; | ||
| import org.springframework.beans.factory.InitializingBean; | ||
|
|
||
| import java.util.*; |
| import org.springframework.util.Assert; | ||
| import org.springframework.util.CollectionUtils; | ||
| import org.springframework.util.StringUtils; | ||
|
|
||
| import java.util.*; |
| import io.qdrant.client.grpc.Collections.Distance; | ||
| import io.qdrant.client.grpc.Collections.VectorParams; | ||
| import io.qdrant.client.grpc.JsonWithInt.Value; | ||
| import io.qdrant.client.grpc.Points.*; |
| import redis.clients.jedis.search.IndexDataType; | ||
| import redis.clients.jedis.search.Query; | ||
| import redis.clients.jedis.search.RediSearchUtil; | ||
| import redis.clients.jedis.search.*; |
| import redis.clients.jedis.search.schemafields.TagField; | ||
| import redis.clients.jedis.search.schemafields.TextField; | ||
| import redis.clients.jedis.search.schemafields.VectorField; | ||
| import redis.clients.jedis.search.schemafields.*; |
| import redis.clients.jedis.search.schemafields.VectorField.VectorAlgorithm; | ||
|
|
||
| import java.text.MessageFormat; | ||
| import java.util.*; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
general low hanging optimization and polish
VectorStoreimplementations so that if they implementedInitializingBean, they now implementApplicationListener<ApplicationReadyEvent>, instead. The result is that the vector stores now initialize their own state after the boot app has started. this is important because a) nobody wants to wait 2x as long for their app to run SQL statements or create collections or whatever, especially when developing, and nobody wants their Kubernetes health check to fail for stuff that can be done after the application's fully online.ChromaVectorStore? Should we add their author tag? do we need ChromaVectorStore#SIMILARITY_THRESHOLD_ALL and ChromaVectorStore#SIMILARITY_THRESHOLD_ALLspring-ai-azure-vector-storetospring-ai-azure-storeto match other vector storesartifactIdspom.xmlnameelements looked consistent (try running./mvnw cleanand you'll see the output is nicer)