fix : use ollamacontainer endpoint #680
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of manually setting the url use containers OOTB URL
| @@ -73,7 +73,7 @@ public static void beforeAll() throws IOException, InterruptedException { | |||
| ollamaContainer.execInContainer("ollama", "pull", MODEL); | |||
| logger.info(MODEL + " pulling competed!"); | |||
|
|
|||
| baseUrl = "http://" + ollamaContainer.getHost() + ":" + ollamaContainer.getMappedPort(11434); | |||
| baseUrl = ollamaContainer.getEndpoint(); | |||
There was a problem hiding this comment.
you are smashing the host configuration. I think would be better to allow both configurations. If the endpoint is set, then get the endpoint, but if the endpoint is not set, then leave the code as it is to allow setting by host
There was a problem hiding this comment.
Hi @f3rnandomoreno , since this is using TestContainers under the hood, getEndPoint() will set the host. No need to explicitly set it.
Also, getEndpoint() cannot be null if container is started
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of manually setting the url use containers OOTB URL