Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use WebClient.Builder and RestClient.Builder From Spring Dependency Injection Mechanism for OpenAI. #675

Closed

Conversation

deepakn27
Copy link
Contributor

@deepakn27 deepakn27 commented May 3, 2024

Closes #609

Previously, the code employed WebClient.builder() and RestClient.builder() directly for constructing instances without making use of Spring's dependency injection capabilities.
This direct approach posed limitations, particularly in scenarios where users wished to extend or modify the configuration of WebClient. Unfortunately, due to the direct instantiation, such customization was not feasible.

To address this limitation, the fix introduces a more robust solution by embracing Spring's dependency injection mechanism. By leveraging this capability, configuration and management of these builders are now centralized within the Spring application context. This empowers users to easily extend, customize, or override configurations as needed, enhancing the flexibility and maintainability of the codebase.

@deepakn27 deepakn27 changed the title fix: Use WebClient.Builder and RestClient.Builder From Spring Dependency Injection Mechanism for OpenAI. fixes #609 fix: Use WebClient.Builder and RestClient.Builder From Spring Dependency Injection Mechanism for OpenAI. Closes#609 May 3, 2024
@deepakn27 deepakn27 changed the title fix: Use WebClient.Builder and RestClient.Builder From Spring Dependency Injection Mechanism for OpenAI. Closes#609 fix: Use WebClient.Builder and RestClient.Builder From Spring Dependency Injection Mechanism for OpenAI. May 3, 2024
@markpollack markpollack self-assigned this May 8, 2024
@markpollack markpollack added this to the 1.0.0-M1 milestone May 8, 2024
@markpollack
Copy link
Member

Thanks, sorry it took so long. Closed in 377b5ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for customization of webclient for OpenAI
2 participants