Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Git shallow clone for better performance #2403

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Git shallow clone for better performance #2403

wants to merge 1 commit into from

Conversation

pukkaone
Copy link

@pukkaone pukkaone commented Apr 9, 2024

Do not download the entire commit history from the remote. Execute the equivalent of git clone --depth 1

Fixes #1544

spencergibb
spencergibb requested changes Apr 9, 2024
View reviewed changes
Copy link
Member

@spencergibb spencergibb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately we can't make a change like this that changes the default existing behavior for everyone in a minor.

@spencergibb
Copy link
Member

Maybe if you make it opt in with a configuration flag

@pukkaone
Git shallow clone for better performance
d0c8281 
Do not download the entire commit history from the remote.  Execute the
equivalent of `git clone --depth 1`

Fixes spring-cloud#1544
@pukkaone
Copy link
Author

pukkaone commented Apr 9, 2024

I added a configuration flag where the default is the existing behavior.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spencergibb spencergibb spencergibb requested changes

Assignees
No one assigned
Labels
waiting-for-triage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shallow clone for better performance
3 participants
@pukkaone @spencergibb @spring-cloud-issues