Cross-build scalacheck module on scala 3 #857
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #857 +/- ##
==========================================
- Coverage 95.18% 95.16% -0.02%
==========================================
Files 51 52 +1
Lines 1827 1821 -6
Branches 153 159 +6
==========================================
- Hits 1739 1733 -6
Misses 88 88 ☔ View full report in Codecov by Sentry. |
RustedBones
force-pushed
the
scala3-scalacheck
branch
2 times, most recently
from
bcaf9c4
to
27c1fb2
Compare
scalacheck/src/test/scala/magnolify/scalacheck/CogenDerivationSuite.scala
Outdated
Show resolved
Hide resolved
| @@ -0,0 +1,58 @@ | |||
| /* | |||
| * Copyright 2019 Spotify AB | |||
There was a problem hiding this comment.
| * Copyright 2019 Spotify AB | |
| * Copyright 2023 Spotify AB |
| Gen.choose(0, subtypes.size - 1) | ||
| } else { | ||
| // pick a fixed subtype to have a chance to stop recursion | ||
| Gen.const(subtypes.size + size) |
There was a problem hiding this comment.
I'm not totally following the subtypes.size + size logic, can you explain a bit?
There was a problem hiding this comment.
Once we reach negative size, we'll stop picking type at random, and deterministically pick one of the subtype. This is done so we'll have a chance to end-up recursion when tree structure is big.
The downside is that such generated struct will often have the same kind of tali/leaves
There was a problem hiding this comment.
This was previously done by providing the Fallback implicit.
| } | ||
| } | ||
|
|
||
| implicit def gen[T]: Arbitrary[T] = macro Magnolia.gen[T] |
There was a problem hiding this comment.
I like this signature change, it matches the Scalacheck API better too imo 👍
RustedBones
force-pushed
the
scala3-scalacheck
branch
from
c978456
to
5640767
Compare
RustedBones
force-pushed
the
scala3-scalacheck
branch
from
889d14f
to
0125b32
Compare
Keep type param Add missing headers Prefer explicit imports instead of trait mixin Revert to implicit in shared Use implicit instead of given Add missing header Fix scala3 warning Remove trace Change year in header Update doc Simplify arbitrary derivation Update to next minor version Use import instead of mixin trait Avoid implicit name conflict Streamline macro naming Change macro naming
RustedBones
force-pushed
the
scala3-scalacheck
branch
from
0125b32
to
58fc597
Compare
Looks like magnolia scala3 is creating a lambda with iuter reference in the
SubType.callByNeedhere that prevents the typeclass to be serializable.Changed the usage in
semiautoto get more consistency with native magnolify typeclasses