Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

Getting script to work with /bin/sh #59

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jasonm-makerbot
Copy link

Getting script to work with /bin/sh so you can use it on docker-machine or boot2docker as they are minimal distributions that do not contain bash. The script still works when run by bash however.

@extemporalgenome
Copy link

I can confirm that this works well inside of docker-machine -- there's nothing in the script that really "needs" bash.

@konstruktoid
Copy link
Contributor

Even if you change /bin/bash to /bin/sh, the script still contains some bashism:

$ sudo dash docker-gc
docker-gc: 81: docker-gc: function: not found
$ sudo /bin/sh docker-gc
docker-gc: 81: docker-gc: function: not found
$ shellcheck docker-gc | grep -c -e 'SC.*:'
52

@mattnworb
Copy link
Member

There were functions added to docker-gc after this PR was created, so while this merges cleanly the result is not bash compatible any more.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants