Add failing tests for reading just produced output avro files. #578
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Print user-provided Avro schema to a log.
labianchin
reviewed
Apr 3, 2023
dbeam-core/src/main/java/com/spotify/dbeam/avro/BeamJdbcAvroSchema.java
Outdated
Show resolved
Hide resolved
dbeam-core/src/test/java/com/spotify/dbeam/jobs/JdbcAvroJobTest.java
Outdated
Show resolved
Hide resolved
dbeam-core/src/test/java/com/spotify/dbeam/jobs/JdbcAvroJobTest.java
Outdated
Show resolved
Hide resolved
| int result = | ||
| new DataFileReadTool() | ||
| .run(System.in, System.out, System.err, Arrays.asList("--head", outputAvroFile)); | ||
| Assert.assertEquals(0, result); // old school :) |
There was a problem hiding this comment.
What does "old school :)" mean?
There was a problem hiding this comment.
0 returned meaning "success".
|
|
||
| int result = | ||
| new DataFileReadTool() | ||
| .run(System.in, System.out, System.err, Arrays.asList("--head", outputAvroFile)); |
There was a problem hiding this comment.
Why do we need DataFileReadTool from a separate jar. Can we simply use something like the other tests is using, readAvroRecords(outputPath.resolve("part-00000-of-00001.avro").toFile(), schema).
There was a problem hiding this comment.
I guess the idea is to use an "independent" but trustworthy tool to illustrate real-world usage.
…hema.java Co-authored-by: Luís Bianchin <labianchin@users.noreply.github.com>
…t.java Co-authored-by: Luís Bianchin <labianchin@users.noreply.github.com>
…t.java Co-authored-by: Luís Bianchin <labianchin@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print user-provided Avro schema to a log.
Unit-tests to illustrate existing issues when incorrect user-supplied Avro schema is used. #579
Testing
Checklist for PR author(s)
mvn com.coveo:fmt-maven-plugin:format org.codehaus.mojo:license-maven-plugin:update-file-header)