Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Install GraphViz before building docs on GitHub #1905

Merged
merged 2 commits into from
Mar 4, 2024

Conversation

Vampire
Copy link
Member

@Vampire Vampire commented Mar 2, 2024

No description provided.

Copy link
Member Author

Vampire commented Mar 2, 2024

This stack of pull requests is managed by Graphite. Learn more about stacking.

Join @Vampire and the rest of your teammates on Graphite Graphite

@leonard84
Copy link
Member

Maybe we don't need it, there is an Java port of graphviz integrated into plantuml.

https://plantuml.com/smetana02 I'll have a look at that first.

@Vampire Vampire force-pushed the vampire/fix-diagram-creation-on-github branch from a1de5f0 to b59bf33 Compare March 4, 2024 01:44
Copy link
Member Author

Vampire commented Mar 4, 2024

Maybe we don't need it, there is an Java port of graphviz integrated into plantuml.

https://plantuml.com/smetana02 I'll have a look at that first.

Ah, nice.
I was not aware that a Java port of GraphViz even exists.
Last time I searched for one, the only things available were Java bridges to the still native implementation or tool.
But if that is really plain Java, it would of course be preferable.

@Vampire
Copy link
Member Author

Vampire commented Mar 4, 2024

Hm, I'm not too convinced of Smetana from a first try. :-D
GraphViz:
image
Smetana:
image
My main concern is not the density, but more the arabic ordering. (plantuml/plantuml#1703)

@Vampire Vampire requested a review from leonard84 March 4, 2024 02:03
@leonard84 leonard84 merged commit 6002d32 into master Mar 4, 2024
39 checks passed
@leonard84 leonard84 deleted the vampire/fix-diagram-creation-on-github branch March 4, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants