chore(ci): Upgrade workflows to non-deprecated runtimes #1142
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi!
The several of the workflows in this repo is using a deprecated Node.js 12 runtime. Github have announced that everyone should move away from the deprecated Node.js runtime as of this blogpost.
In addition to bumping reusable action versions I've done two major changes:
.envfile into the$GITHUB_ENVparameter.setup-dockersteps as this is not needed when running your actions onubuntu-latestfrom GitHub.In the
prodsec-workflow.ymlI see that the .env file has been loaded before, but I see no references to the output step as I have seen in other pipelines. I've updated this as well, but if my assumptions is correct and it's not in use - please let me know so I can remove this code.The deprecated runtime in bias-language-workflow.yml will be fixed by this pull request
I've tried my best to have several looks and make sure that I've covered all steps, but please give it a good set of extra eyes to make sure that no bumps or replacements have been missed.