Set default time #213
Open
Set default time #213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
November 9, 2021 16:08
If no header/body serializer provides time information, and the log event contains a time value, then set that into the JSON header. This allows accurate logging of time information, rather than just using the batch arrival time as the timestamp.
mbukowski-splunk
suggested changes
Aug 17, 2022
| @@ -63,6 +63,10 @@ public String serialize(HttpEventCollectorEventInfo info) { | |||
| } else { | |||
| event.put("event", info); | |||
| } | |||
| if (!event.containsKey("time") && info.getTime() > 0) { | |||
There was a problem hiding this comment.
Maybe it is worth to create a separate method for that part one the time is not specified?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the header or body serializers do not set the time in the header, then use the time data from the event.
This stops the events from just using the batch arrival time, which is effectively a useless time.