Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate unused BUSYBOX_URL variable #669

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

alexhaydock
Copy link

As of the most recent commit, 0de4bff, I can see that the URL to download Busybox into the RHEL 8 UBI container is being hard-coded into the install.sh script:

wget https://busybox.net/downloads/busybox-1.36.1.tar.bz2

This seems to deprecate the previous lines:

BUSYBOX_URL=${BUSYBOX_URL:=https://busybox.net/downloads/binaries/1.35.0-`arch`-linux-musl/busybox}
wget -O /bin/busybox ${BUSYBOX_URL}
chmod +x /bin/busybox

It seems like this was mainly being used in the Makefile for the armv8 RHEL8 container, passed in as a build-arg, which overrode the default:

docker-splunk/Makefile

Lines 77 to 78 in 0de4bff

base-redhat-8-armv8:
docker buildx build ${DOCKER_BUILD_FLAGS} --build-arg BUSYBOX_URL=${BUSYBOX_URL} --label version=${SPLUNK_VERSION} -t base-redhat-8-armv8:${IMAGE_VERSION} ./base/redhat-8

I guess this needed overriding for the armv8 container since Busybox don't seem to publish aarch64 builds at that URL above.

But now, as of 0de4bff, we're building from source and not actually using the $BUSYBOX_URL variable anywhere, this is having no effect even if we do pass it in as a build-arg. So for clarity, we might as well remove the variable entirely.

@alexhaydock alexhaydock requested a review from a team as a code owner April 22, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant